fix(browser_adapter.ts): baseElement.getAttribute

modules/angular2/src/dom/browser_adapter.ts

@@ -292,6 +292,7 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
     }
     return relativePath(href);
   }
+  resetBaseElement(): void { baseElement = null; }
   getUserAgent(): string { return window.navigator.userAgent; }
   setData(element, name: string, value: string) { element.dataset[name] = value; }
   getData(element, name: string): string { return element.dataset[name]; }
@@ -308,7 +309,7 @@ function getBaseElementHref(): string {
       return null;
     }
   }
-  return baseElement.attr('href');
+  return baseElement.getAttribute('href');
 }
 
 // based on urlUtils.js in AngularJS 1

modules/angular2/src/dom/dom_adapter.ts

@@ -127,6 +127,7 @@ export class DomAdapter {
   getHistory(): History { throw _abstract(); }
   getLocation(): Location { throw _abstract(); }
   getBaseHref(): string { throw _abstract(); }
+  resetBaseElement(): void { throw _abstract(); }
   getUserAgent(): string { throw _abstract(); }
   setData(element, name: string, value: string) { throw _abstract(); }
   getData(element, name: string): string { throw _abstract(); }

modules/angular2/src/dom/html_adapter.dart

@@ -400,6 +400,10 @@ class Html5LibDomAdapter implements DomAdapter {
     throw 'not implemented';
   }
 
+  resetBaseElement() {
+    throw 'not implemented';
+  }
+
   String getUserAgent() {
     throw 'not implemented';
   }

modules/angular2/src/dom/parse5_adapter.ts

@@ -529,6 +529,8 @@ export class Parse5DomAdapter extends DomAdapter {
       return this.defaultDoc().body;
     }
   }
+  getBaseHref(): string { throw 'not implemented'; }
+  resetBaseElement(): void { throw 'not implemented'; }
   getHistory(): History { throw 'not implemented'; }
   getLocation(): Location { throw 'not implemented'; }
   getUserAgent(): string { return "Fake user agent"; }

modules/angular2/test/dom/dom_adapter_spec.ts

@@ -49,5 +49,56 @@ export function main() {
       expect(DOM.isElementNode(secondChild)).toBe(true);
 
     });
+
+    if (DOM.supportsDOMEvents()) {
+      it('should getBaseHref should return null if blank', () => {
+
+        var subject = DOM.getBaseHref();
+        var result = null;
+
+        expect(subject).toEqual(result);
+      });
+
+      it('should getBaseHref correctly', () => {
+
+        DOM.resetBaseElement();
+        var result = '/drop/bass/connon/';
+
+        var $base = DOM.createElement('base');
+        DOM.setAttribute($base, 'href', result);
+        var $head = DOM.defaultDoc().head;
+        DOM.appendChild($head, $base);
+
+
+        var subject = DOM.getBaseHref();
+        DOM.removeChild($head, $base);
+        DOM.resetBaseElement();
+
+        expect(subject).toEqual(result);
+
+      });
+
+      it('should getBaseHref relative url', () => {
+
+        DOM.resetBaseElement();
+        var initialValue = 'bass';
+
+        var $base = DOM.createElement('base');
+        DOM.setAttribute($base, 'href', initialValue);
+        var $head = DOM.defaultDoc().head;
+        DOM.appendChild($head, $base);
+
+
+        var result = '/' + initialValue;
+        var subject = DOM.getBaseHref();
+        DOM.removeChild($head, $base);
+        DOM.resetBaseElement();
+
+        expect(subject).toEqual(result);
+
+      });
+    }
+
+
   });
-}
+}