Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(service-worker): mention that dataGroups only cache non-mutating requests #32142

Closed
wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Service Worker doc does not mention that only non-mutating requests (GET and HEAD) are cached.

Issue Number: #28988

What is the new behavior?

Limitation is mentioned in https://angular.io/guide/service-worker-config#datagroups

Does this PR introduce a breaking change?

  • Yes
  • No

@jbogarthyde jbogarthyde added type: bug/fix comp: docs effort1: hours freq1: low aio: preview target: patch This PR is targeted for the next patch release area: service-worker Issues related to the @angular/service-worker package risk: low labels Aug 14, 2019
@jbogarthyde jbogarthyde requested a review from a team as a code owner August 14, 2019 19:02
@jbogarthyde jbogarthyde self-assigned this Aug 14, 2019
@ngbot ngbot bot modified the milestone: Backlog Aug 14, 2019
@jbogarthyde jbogarthyde changed the title docs: sw request cacheing limitation Doc SW limitation on cacheing request URLs Aug 14, 2019
@mary-poppins
Copy link

You can preview fd84898 at https://pr32142-fd84898.ngbuilds.io/.

@jbogarthyde jbogarthyde added this to In Review in docs Aug 14, 2019
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the commit message to something like:

docs(service-worker): mention that dataGroups only cache non-mutating requests

aio/content/guide/service-worker-config.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 1cfec06 at https://pr32142-1cfec06.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1fdfac0 at https://pr32142-1fdfac0.ngbuilds.io/.

@gkalpak gkalpak changed the title Doc SW limitation on cacheing request URLs docs(service-worker): mention that dataGroups only cache non-mutating requests Aug 14, 2019
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to mention it before:
You need to mention that this fixes #28988 in the commit message:

docs(service-worker): mention that dataGroups only cache non-mutating requests

Fixes #28988

@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 14, 2019
@jbogarthyde jbogarthyde removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 14, 2019
@mary-poppins
Copy link

You can preview bef8b5e at https://pr32142-bef8b5e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 78381a5 at https://pr32142-78381a5.ngbuilds.io/.

@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Aug 19, 2019
AndrewKushnir pushed a commit that referenced this pull request Aug 19, 2019
@jbogarthyde jbogarthyde moved this from In Review to Done in docs Aug 20, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: service-worker Issues related to the @angular/service-worker package cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants