New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(service-worker): mention that dataGroups
only cache non-mutating requests
#32142
Conversation
You can preview fd84898 at https://pr32142-fd84898.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the commit message to something like:
docs(service-worker): mention that
dataGroups
only cache non-mutating requests
1cfec06
to
1fdfac0
Compare
You can preview 1cfec06 at https://pr32142-1cfec06.ngbuilds.io/. |
You can preview 1fdfac0 at https://pr32142-1fdfac0.ngbuilds.io/. |
dataGroups
only cache non-mutating requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1fdfac0
to
bef8b5e
Compare
You can preview bef8b5e at https://pr32142-bef8b5e.ngbuilds.io/. |
bef8b5e
to
78381a5
Compare
You can preview 78381a5 at https://pr32142-78381a5.ngbuilds.io/. |
… requests (angular#32142) Fixes angular#28988 PR Close angular#32142
… requests (angular#32142) Fixes angular#28988 PR Close angular#32142
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Service Worker doc does not mention that only non-mutating requests (GET and HEAD) are cached.
Issue Number: #28988
What is the new behavior?
Limitation is mentioned in https://angular.io/guide/service-worker-config#datagroups
Does this PR introduce a breaking change?