Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't create holey arrays #32155

Closed
wants to merge 7 commits into from
Closed

perf: don't create holey arrays #32155

wants to merge 7 commits into from

Commits on Aug 20, 2019

  1. perf: don't create holey arrays 

    Don't use `Array` constructor with the size value (ex. `new Array(5)`) - this will create a `HOLEY_ELEMENTS` array (even if this array is filled in later on!);

https://v8.dev/blog/elements-kinds
https://stackoverflow.com/questions/32054170/how-to-resize-an-array
    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    df409b7 View commit details
    Browse the repository at this point in the history

  2. fixup! perf: don't create holey arrays

    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    2d76677 View commit details
    Browse the repository at this point in the history

  3. fixup! perf: don't create holey arrays

    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    6a89d55 View commit details
    Browse the repository at this point in the history

  4. fixup! perf: don't create holey arrays

    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    3d4f825 View commit details
    Browse the repository at this point in the history

  5. fixup! perf: don't create holey arrays

    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    a8ccd49 View commit details
    Browse the repository at this point in the history

  6. fixup! perf: don't create holey arrays

    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    8676fa7 View commit details
    Browse the repository at this point in the history

  7. fixup! perf: don't create holey arrays

    @mhevery
    mhevery committed Aug 20, 2019
    Copy the full SHA
    4eb0f47 View commit details
    Browse the repository at this point in the history