Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make largetable test work in g3 #32275

Closed
wants to merge 1 commit into from
Closed

test: make largetable test work in g3 #32275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions modules/benchmarks/src/largetable/render3/BUILD.bazel
View file
Open in desktop
Expand Up @@ -6,21 +6,23 @@ load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")

ng_module(
name = "largetable_lib",
srcs = glob(["**/*.ts"]),
srcs = [
"index_aot.ts",
"table.ts",
],
tags = ["ivy-only"],
deps = [
"//modules/benchmarks/src:util_lib",
"//modules/benchmarks/src/largetable:util_lib",
"//packages:types",
"//packages/common",
"//packages/core",
"@npm//reflect-metadata",
],
)

ng_rollup_bundle(
name = "bundle",
entry_point = ":index.ts",
entry_point = ":index_aot.ts",
tags = ["ivy-only"],
deps = [
":largetable_lib",
Expand All @@ -30,12 +32,12 @@ ng_rollup_bundle(

ts_devserver(
name = "devserver",
static_files = [
index_html = "index.html",
port = 4200,
tags = ["ivy-only"],
deps = [
":bundle.min_debug.js",
":bundle.min.js",
"index.html",
],
tags = ["ivy-only"],
)

benchmark_test(
Expand Down
6 changes: 0 additions & 6 deletions modules/benchmarks/src/largetable/render3/index.html
View file
Open in desktop
Expand Up @@ -28,12 +28,6 @@ <h2>Render3 Largetable Benchmark</h2>
<largetable id="root"></largetable>
</div>

<script>
// TODO(mlaval): remove once we have a proper solution
ngDevMode = false;
var bazelBundle = document.location.search.endsWith('debug') ? 'bundle.min_debug.js' : 'bundle.min.js';
document.write('<script src="' + bazelBundle + '">\u003c/script>');
</script>
</body>

</html>
1 change: 0 additions & 1 deletion ...enchmarks/src/largetable/render3/index.ts → ...marks/src/largetable/render3/index_aot.ts
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import 'reflect-metadata';
import {ɵrenderComponent as renderComponent} from '@angular/core';

import {bindAction, profile} from '../../util';
Expand Down