Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove universalProject option from app shell docs #32281

Closed
wants to merge 1 commit into from
Closed

docs: remove universalProject option from app shell docs #32281

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

This option has been deprecated in verson 9 as it has no effect
angular/angular-cli#15394

This option has been deprecated in verson 9 as it has no effect
angular/angular-cli#15394
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker comp: docs target: major This PR is targeted for the next major release labels Aug 23, 2019
@alan-agius4 alan-agius4 requested a review from a team as a code owner August 23, 2019 06:06
@ngbot ngbot bot modified the milestone: needsTriage Aug 23, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 26, 2019
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @alan-agius4!

@kapunahelewong kapunahelewong added this to Waiting for Merge in docs Aug 26, 2019
@atscott atscott closed this in ae9960b Aug 26, 2019
@alan-agius4 alan-agius4 deleted the app-shell-docs branch August 26, 2019 17:07
@kapunahelewong kapunahelewong moved this from Waiting for Merge to Done in docs Aug 26, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
This option has been deprecated in verson 9 as it has no effect
angular/angular-cli#15394

PR Close angular#32281
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
This option has been deprecated in verson 9 as it has no effect
angular/angular-cli#15394

PR Close angular#32281
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
This option has been deprecated in verson 9 as it has no effect
angular/angular-cli#15394

PR Close angular#32281
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: major This PR is targeted for the next major release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants