Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): undecorated-classes-with-di migration should never use ngtsc #32318

Closed
wants to merge 2 commits into from
Closed

refactor(core): undecorated-classes-with-di migration should never use ngtsc #32318

wants to merge 2 commits into from

Commits on Aug 26, 2019

  1. refactor(core): undecorated-classes-with-di migration should never us… 

    …e ngtsc

ec4381d enabled Ivy by default. This is
problematic as migrations like `undecorated-classes-with-di` depend on the
`AngularCompilerProgram` (NGC) in order to perform the migration from
version 8 to version 9. In order to ensure that the migration always runs
with NGC (and doesn't get the `NgtscProgram`), we need to explicitly disable
ivy when creating the `@angular/compiler-cli` program for the migration.
    @devversion
    devversion committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    43e8b15 View commit details
    Browse the repository at this point in the history

  2. test(core): cleanup bazel target names for schematic tests 

    Apparently the names of the bazel test targets in the schematics are
incorrect. This commit updates the target names to match their bazel
package name.
    @devversion
    devversion committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    d40986b View commit details
    Browse the repository at this point in the history