Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): unable to bind to properties that start with class or style #32421

Closed
wants to merge 1 commit into from
Closed

fix(ivy): unable to bind to properties that start with class or style #32421

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 30, 2019 •
edited

Fixes Ivy picking up property bindings that start with class or style as if they're style bindings.

Fixes #32310.

@crisbeto crisbeto added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Aug 30, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 30, 2019
@crisbeto crisbeto marked this pull request as ready for review August 30, 2019 17:56
@crisbeto crisbeto requested review from a team as code owners August 30, 2019 17:56
kara
kara approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara
Copy link
Contributor

kara commented Aug 30, 2019

@crisbeto Can we amend the commit message to say that it closes #32310?

@kara kara added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 30, 2019
@crisbeto
Copy link
Member Author

Added the closes reference to the commit message.

@kara
Copy link
Contributor

kara commented Aug 30, 2019 •
edited

VE presubmit

Ivy presubmit

@crisbeto
fix(ivy): unable to bind to properties that start with class or style
73da5fc 
Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes angular#32310
@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Sep 5, 2019
@ngbot
Copy link

ngbot bot commented Sep 5, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_aio" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 5, 2019
@kara
Copy link
Contributor

kara commented Sep 5, 2019

merge-assistance: global approval

@matsko matsko closed this in 62d92f8 Sep 5, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@crisbeto @sabeersulaiman
fix(ivy): unable to bind to properties that start with class or style (…
b58b979 
…angular#32421)

Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes angular#32310

PR Close angular#32421
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@crisbeto @arnehoek
fix(ivy): unable to bind to properties that start with class or style (…
21c4a88 
…angular#32421)

Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes angular#32310

PR Close angular#32421
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsko matsko matsko left review comments

@jelbourn jelbourn jelbourn left review comments

@kara kara kara approved these changes

@gkalpak gkalpak gkalpak left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

[ivy] If an @Input *begins* with the word 'class' it is treated as a CSS class
6 participants
@crisbeto @kara @matsko @jelbourn @gkalpak @googlebot