Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update codeowners to reflect GitHub team members #32569

Closed
wants to merge 3 commits into from
Closed

ci: update codeowners to reflect GitHub team members #32569

wants to merge 3 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Sep 10, 2019

☝️

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project state: blocked target: patch This PR is targeted for the next patch release labels Sep 10, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 10, 2019
josephperrott
josephperrott reviewed Sep 10, 2019
View reviewed changes
.github/CODEOWNERS
@@ -44,14 +44,10 @@
# alxhub - Alex Rickabaugh
# AndrewKushnir - Andrew Kushnir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add atscott - Andrew Scott

josephperrott
josephperrott requested changes Sep 10, 2019
View reviewed changes
.github/CODEOWNERS Outdated
@@ -127,7 +121,6 @@
#
# - alexeagle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexeagle should be removed from:
@angular/framework-global-approvers
@angular/tools-cli
@angular/fw-integration
@angular/fw-docs-packaging
@angular/tools-docs-libraries
@angular/tools-docs-schematics

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed (and updated those teams in CODEOWNERS to match the actual GitHub teams).

@gkalpak gkalpak force-pushed the ci-update-codeowners-members branch 2 times, most recently from 4ea5a3b to 13319c0 Compare September 10, 2019 21:27
@gkalpak gkalpak marked this pull request as ready for review September 10, 2019 21:44
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Sep 10, 2019
@gkalpak
Copy link
Member Author

gkalpak commented Sep 11, 2019

The CI failures are unrelated to this PR (and will be fixed by #32602).

josephperrott
josephperrott approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks! I know this was tedious work to have to manage the Github UI to get all of this info lined up.

@gkalpak
Copy link
Member Author

gkalpak commented Sep 11, 2019

(Rebased on master to make CI happy.)

kara
kara requested changes Sep 11, 2019
View reviewed changes
.github/CODEOWNERS Show resolved Hide resolved
kara
kara approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 11, 2019
@kara
Copy link
Contributor

kara commented Sep 11, 2019

merge-assistance: global approval (note: Igor approved these changes over IM)

@matsko matsko closed this in 5356826 Sep 12, 2019
matsko pushed a commit that referenced this pull request Sep 12, 2019
@gkalpak @matsko
ci: update codeowners to reflect GitHub team members (#32569)
08a7c6f 
PR Close #32569
@gkalpak gkalpak deleted the ci-update-codeowners-members branch September 12, 2019 09:50
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@gkalpak @arnehoek
ci: update codeowners to reflect GitHub team members (angular#32569)
3220253 
PR Close angular#32569
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@josephperrott josephperrott josephperrott approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @kara @josephperrott @googlebot