Perf set changing prop #32574
Closed
Perf set changing prop #32574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
comp: ivy
action: review
|
|
pkozlowski-opensource
force-pushed
the
perf_set_changing_prop
branch
from
f1cca3a
to
db8701e
Compare
While determining a property name to bind to we were checking a mapping object resulting in the megamorphic read. Replacing such read with a series of if checks speeds up rproprty update benchmark ~30% (~1400ms down to ~1000ms).
mhevery
approved these changes
Sep 10, 2019
mhevery
added
action: merge
kara
approved these changes
Sep 10, 2019
| * | ||
| * Performance note: this function is written as a series of if checks (instead of, say, a property | ||
| * object lookup) for performance reasons - the series of `if` checks seems to be the fastest way of | ||
| * mapping property names. Do NOT change without benchmarking. |
mhevery
reviewed
Sep 10, 2019
| 'tabindex': 'tabIndex', | ||
| }; | ||
| function mapPropName(name: string): string { | ||
| if (name === 'class') return 'className'; |
There was a problem hiding this comment.
I wonder if we could make this even faster if we did something like this:
const ch = name.charCodeAt(0);
if (ch === 99 /*c*/ || ch === 102 /*f*/' || ch === 105 /*i*/ || ch === 116 /*t*/ || ch === 't') {
...
}
matsko
pushed a commit
that referenced
this pull request
Sep 12, 2019
While determining a property name to bind to we were checking a mapping object resulting in the megamorphic read. Replacing such read with a series of if checks speeds up rproprty update benchmark ~30% (~1400ms down to ~1000ms). PR Close #32574
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
…2574) While determining a property name to bind to we were checking a mapping object resulting in the megamorphic read. Replacing such read with a series of if checks speeds up rproprty update benchmark ~30% (~1400ms down to ~1000ms). PR Close angular#32574
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new benchmark that focuses on performance of property updates. It also contain a fix where by removing a megamorphic access we can speed up this new benchmark by ~30%.
Review commit by commit and check individual commit message for more details.