Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): avoid unnecessary i18n instructions generation for <ng-template> with structural directives #32623

Closed
wants to merge 4 commits into from
Closed

fix(ivy): avoid unnecessary i18n instructions generation for <ng-template> with structural directives #32623

wants to merge 4 commits into from

Commits on Sep 13, 2019

  1. fix(ivy): avoid unnecessary i18n instructions generation for <ng-temp… 

    …late> with structural directives

If an <ng-template> contains a structural directive (for example *ngIf), Ngtsc generates extra template function with 1 template instruction call. When <ng-template> tag also contains i18n attribute on it, we generate i18nStart and i18nEnd instructions around it, which is unnecessary and breaking runtime. This commit adds a logic to make sure we do not generate i18n instructions in case only `template` is present.
    @AndrewKushnir
    AndrewKushnir committed Sep 13, 2019
    Copy the full SHA
    20e0a32 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(ivy): avoid unnecessary i18n instructions generation for <… 

    …ng-template> with structural directives
    @AndrewKushnir
    AndrewKushnir committed Sep 13, 2019
    Copy the full SHA
    0a2ed63 View commit details
    Browse the repository at this point in the history

  3. fixup! fix(ivy): avoid unnecessary i18n instructions generation for <… 

    …ng-template> with structural directives
    @AndrewKushnir
    AndrewKushnir committed Sep 13, 2019
    Copy the full SHA
    38e79e7 View commit details
    Browse the repository at this point in the history

  4. fixup! fix(ivy): avoid unnecessary i18n instructions generation for <… 

    …ng-template> with structural directives
    @AndrewKushnir
    AndrewKushnir committed Sep 13, 2019
    Copy the full SHA
    bd7f42b View commit details
    Browse the repository at this point in the history