Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docs-infra): update in-memory-we-api and karma-jasmine-html-reporter version #32892

Closed
wants to merge 1 commit into from
Closed

build(docs-infra): update in-memory-we-api and karma-jasmine-html-reporter version #32892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions aio/tools/examples/shared/package.json
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@
"@nguniversal/express-engine": "^8.0.0-rc.1",
"@nguniversal/module-map-ngfactory-loader": "^8.0.0-rc.1",
"angular": "1.7.8",
"angular-in-memory-web-api": "github:brandonroberts/in-memory-web-api-bazel#50a34d8",
"angular-in-memory-web-api": "^0.9.0",
"angular-route": "1.7.8",
"core-js": "^2.5.4",
"express": "^4.14.1",
Expand Down Expand Up @@ -69,7 +69,7 @@
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.1",
"karma-jasmine": "~2.0.1",
"karma-jasmine-html-reporter": "^0.2.2",
"karma-jasmine-html-reporter": "^1.4.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making the change. Can you, please, also update the commit message (to indicate that this is not just about in-memory-web-api (or move this change to a separate PR) and also mention that this fixes taras42/karma-jasmine-html-reporter#31?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the commit message.

Copy link
Member

@gkalpak gkalpak Sep 30, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, can you please mention that the karma-jasmine-html-reporter update also fixes taras42/karma-jasmine-html-reporter#31 in the commit message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if its fine I was not able to mention that in the message so added in Fixes

"lite-server": "^2.2.2",
"lodash": "^4.16.2",
"protractor": "~5.4.0",
Expand Down
22 changes: 8 additions & 14 deletions aio/tools/examples/shared/yarn.lock
View file
Open in desktop
Expand Up @@ -795,11 +795,10 @@ amdefine@>=0.0.4:
version "1.0.1"
resolved "https://registry.yarnpkg.com/amdefine/-/amdefine-1.0.1.tgz#4a5282ac164729e93619bcfd3ad151f817ce91f5"

"angular-in-memory-web-api@github:brandonroberts/in-memory-web-api-bazel#50a34d8":
version "0.8.0"
resolved "https://codeload.github.com/brandonroberts/in-memory-web-api-bazel/tar.gz/50a34d84b627ec88816242dec77603d6dcb9c880"
dependencies:
tslib "^1.9.0"
angular-in-memory-web-api@^0.9.0:
version "0.9.0"
resolved "https://registry.yarnpkg.com/angular-in-memory-web-api/-/angular-in-memory-web-api-0.9.0.tgz#6c98d9494fadc6b98f54e68376a1998ccfff04bc"
integrity sha512-//PiJ5qb1+Yf/N7270ioQqR2laf4/Irjavg+M+WEn8y4At9LUoYgbQ5HVwvM5xUTlVlL0XkbJRLxREcGGNdIEw==

angular-route@1.7.8:
version "1.7.8"
Expand Down Expand Up @@ -4430,15 +4429,10 @@ karma-coverage-istanbul-reporter@~2.0.1:
istanbul-api "^2.0.5"
minimatch "^3.0.4"

karma-jasmine-html-reporter@^0.2.2:
version "0.2.2"
resolved "https://registry.yarnpkg.com/karma-jasmine-html-reporter/-/karma-jasmine-html-reporter-0.2.2.tgz#48a8e5ef18807617ee2b5e33c1194c35b439524c"
dependencies:
karma-jasmine "^1.0.2"

karma-jasmine@^1.0.2:
version "1.1.0"
resolved "https://registry.yarnpkg.com/karma-jasmine/-/karma-jasmine-1.1.0.tgz#22e4c06bf9a182e5294d1f705e3733811b810acf"
karma-jasmine-html-reporter@^1.4.2:
version "1.4.2"
resolved "https://registry.yarnpkg.com/karma-jasmine-html-reporter/-/karma-jasmine-html-reporter-1.4.2.tgz#16d100fd701271192d27fd28ddc90b710ad36fff"
integrity sha512-7g0gPj8+9JepCNJR9WjDyQ2RkZ375jpdurYQyAYv8PorUCadepl8vrD6LmMqOGcM17cnrynBawQYZHaumgDjBw==

karma-jasmine@~2.0.1:
version "2.0.1"
Expand Down