docs: fix spelling error in angular component class description

[ODAVING]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

• Docs have been added / updated (for bug fixes / features)

• Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[ODAVING]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[petebacondarwin]

To be honest, I think this whole sentence doesn't really make sense and that we should just remove the whole thing. What do you think @jbogarthyde ?

[petebacondarwin]

@ODAVING thanks for submitting this. Please note that the commit message must follow our required syntax: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

[jbogarthyde]

How about:

In Angular, you create a component class to contain the data model and control methods. Use the TypeScript export keyword to export the class so that the functionality can be imported into NgModules.

[ODAVING]

@petebacondarwin and @jbogarthyde thank you for reviewing this. I'll make the changes asap.

[petebacondarwin]

Great! Can you please squash together the two commits?

[kapunahelewong]

Thanks for this, @ODAVING. Could you rebase and then tag me when you're ready? I'd like to help you move this forward. By the way, I have notes on rebasing if you'd find them helpful. Thank you!

[kapunahelewong]

Hm, I think this might be a flake. Or, wait. Did you remember to push up after rebasing? I'm still seeing your branch as being well behind. https://github.com/ODAVING/angular/tree/angular%2332948

[ODAVING]

@kapunahelewong I forced pushed after rebasing it 11 days ago. The ci/circleci: test_aio_local_ivy test keeps failing though.

[ODAVING]

@kapunahelewong The only reason according to circleci_ivy that it's failing is the following message:
"Command 'build-local-with-ivy-ci' not found." Which I don't even know why it would be running it, since it's a simple documentation. Any insight into this would be helpful

[kapunahelewong]

Oh, I thought you meant you'd just rebased today. Could you try it? 🙏🏼

Sometimes there are flakes and a new rebase can help clear them up. I don't think it's anything you've done (since it's referring to Ivy). And if you bring it as up-to-date as possible, that should help. Then if it still fails, either that one or another, it's easier for us to get it green for merge since a whole bunch of other updates are in there. Does that help give context?

[ODAVING]

@kapunahelewong Done, hoping it works this time 🤞

[kapunahelewong]

Yay! It worked! But, I only just noticed that there are two commits. Could you squash? Here are my own notes on the workflow. You're so close! :)

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[ODAVING]

When I try to squash, do I have to go through all 260 commits that my branch was behind of, and 'f' them all? @kapunahelewong

[kapunahelewong]

No, you don't need to go through all those. Just f/fixup the second one. So, here's the way you want to go through it:

git rebase -i HEAD~2

^^That will only give you the option to squash 2 commits. Here's where that command gets me on just some branch I have locally (unrelated to this PR, so disregard the commit messages):

Next, I change the second (my more recent commit) to be f:

Then I save and exit. Now if I do a git log --oneline, I have only the one commit:

57e6e7c75f (HEAD -> my-test-branch) docs: fix animations reference links to api pages

Now, if I were to push up, that single commit would be the one to show up in my PR. My second looks like it's gone, but its work is still in there.

After you've squashed, the rebase will take care of the 260-ish commits. Those should be handled automatically. Does that help?

EDIT: Oh! I see you rebased fine! Well done! Tag me when you've squashed. 🌟

[ODAVING]

I’ll try this again, but Last time I did that, I saw all the 260 commit messages! Will update asap!

…

On Mon, Oct 21, 2019 at 3:45 PM Kapunahele Wong ***@***.***> wrote: No, you don't need to go through all those. Just f/fixup the second one. So, here's the way you want to go through it: git rebase -i HEAD~2 ^^That will only give you the option to squash 2 commits. Here's where that command get me on just some branch I have locally (unrelated to this PR, so disregard the commit messages): [image: image] <https://user-images.githubusercontent.com/4116963/67237157-b7b51080-f418-11e9-9f42-c29ae2555cc0.png> Next, I change the second (my more recent commit) to be f: [image: image] <https://user-images.githubusercontent.com/4116963/67237213-d4514880-f418-11e9-96c9-55c327826b10.png> Then I save and exit. Now if I do a git log --oneline, I have only the one commit: 57e6e7c (HEAD -> my-test-branch) docs: fix animations reference links to api pages Now, if I were to push up, that single commit would be the one to show up in my PR. My second looks like it's gone, but its work is still in there. After you've squashed <https://gist.github.com/kapunahelewong/567c30f7b353fd1c39bbf6d8343e2dca#how-to-rebase>, the rebase will take care of the 260-ish commits. Those should be handled automatically. Does that help? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32971?email_source=notifications&email_token=AFTFEL6UXVE457BV5GOGZHLQPYBEVA5CNFSM4I4Z3P3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3RNHQ#issuecomment-544675486>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFTFEL633MJB5RSO4OSILPLQPYBEVANCNFSM4I4Z3P3A> .

[kapunahelewong]

Look, @ODAVING! I fixed the extra merge commit! (I've never done that before on someone else's PR). Yay!!!!! Rebased and amended!

[kapunahelewong]

Thank you, @ODAVING!!

Merge assistance: global approval for docs changes. Thank you!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}