-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): avoid DOM element assertions if procedural renderer is used #33156
Closed
AndrewKushnir
wants to merge
1
commit into
angular:master
from
AndrewKushnir:no_dom_assert_for_renderer2
Closed
fix(ivy): avoid DOM element assertions if procedural renderer is used #33156
AndrewKushnir
wants to merge
1
commit into
angular:master
from
AndrewKushnir:no_dom_assert_for_renderer2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, Ivy runtime asserted that a given element is an instance of a DOM node. These asserts may not be correct in case custom renderer is used, which operates objects with a shape different than DOM nodes. This commit updates the code to avoid the mentioned checks in case procedural renderer is used.
AndrewKushnir
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
target: major
This PR is targeted for the next major release
comp: ivy
labels
Oct 14, 2019
mhevery
approved these changes
Oct 15, 2019
mhevery
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Oct 15, 2019
AndrewKushnir
added
the
action: presubmit
The PR is in need of a google3 presubmit
label
Oct 15, 2019
pkozlowski-opensource
approved these changes
Oct 15, 2019
AndrewKushnir
removed
the
action: presubmit
The PR is in need of a google3 presubmit
label
Oct 15, 2019
ODAVING
pushed a commit
to ODAVING/angular
that referenced
this pull request
Oct 18, 2019
…angular#33156) Prior to this commit, Ivy runtime asserted that a given element is an instance of a DOM node. These asserts may not be correct in case custom renderer is used, which operates objects with a shape different than DOM nodes. This commit updates the code to avoid the mentioned checks in case procedural renderer is used. PR Close angular#33156
AndrusGerman
pushed a commit
to AndrusGerman/angular
that referenced
this pull request
Oct 22, 2019
…angular#33156) Prior to this commit, Ivy runtime asserted that a given element is an instance of a DOM node. These asserts may not be correct in case custom renderer is used, which operates objects with a shape different than DOM nodes. This commit updates the code to avoid the mentioned checks in case procedural renderer is used. PR Close angular#33156
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
target: major
This PR is targeted for the next major release
type: bug/fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, Ivy runtime asserted that a given element is an instance of a DOM node. These asserts may not be correct in case custom renderer is used, which operates objects with a shape different than DOM nodes. This commit updates the code to avoid the mentioned checks in case procedural renderer is used.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?