Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): deprecate entryComponents #33205

Closed
wants to merge 1 commit into from
Closed

refactor(core): deprecate entryComponents #33205

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 16, 2019 •
edited

With Ivy the entryComponents array isn't necessary anymore. These changes mark it as deprecated so that it can be removed in a future version.

@crisbeto crisbeto force-pushed the FW-1581/entry-components-deprecation branch 2 times, most recently from 8c02a45 to 005d93d Compare October 16, 2019 20:47
@crisbeto crisbeto added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 16, 2019
@mary-poppins
Copy link

You can preview bf7cc34 at https://pr33205-bf7cc34.ngbuilds.io/.
You can preview 8c02a45 at https://pr33205-8c02a45.ngbuilds.io/.
You can preview 005d93d at https://pr33205-005d93d.ngbuilds.io/.

@crisbeto crisbeto marked this pull request as ready for review October 16, 2019 21:35
@crisbeto crisbeto requested review from a team as code owners October 16, 2019 21:35
@JoostK
Copy link
Member

JoostK commented Oct 16, 2019

I think we should also deprecate ANALYZE_FOR_ENTRY_COMPONENTS.

Also, could you fix the commit message

With Ivy the entryComponents array is not necessary anymore.

@crisbeto crisbeto force-pushed the FW-1581/entry-components-deprecation branch from 005d93d to fd545ac Compare October 17, 2019 16:06
@crisbeto
Copy link
Member Author

The feedback has been addressed.

@mary-poppins
Copy link

You can preview fd545ac at https://pr33205-fd545ac.ngbuilds.io/.

@matsko matsko added the area: core Issues related to the framework runtime label Oct 17, 2019
@ngbot ngbot bot added this to the needsTriage milestone Oct 17, 2019
kara
kara approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor nits

packages/core/src/metadata/directives.ts Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 18, 2019
@crisbeto
refactor(core): deprecate entryComponents
c63a8b6 
With Ivy the `entryComponents` array isn't necessary anymore. These changes mark it as deprecated so that it can be removed in a future version.
@crisbeto crisbeto force-pushed the FW-1581/entry-components-deprecation branch from fd545ac to c63a8b6 Compare October 18, 2019 18:48
@crisbeto
Copy link
Member Author

The PR has been addressed.

@crisbeto crisbeto added action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 18, 2019
@crisbeto crisbeto removed their assignment Oct 18, 2019
@kara kara removed the action: presubmit The PR is in need of a google3 presubmit label Oct 18, 2019
@kara kara requested a review from IgorMinar October 18, 2019 18:56
@mary-poppins
Copy link

You can preview c63a8b6 at https://pr33205-c63a8b6.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@kara kara added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2019
@matsko
Copy link
Contributor

matsko commented Oct 18, 2019

Presubmit = http://test/OCL:275534717:BASE:275534776:1571430487778:461a47c4

Ivy Presubmit = http://test/OCL:275534717:BASE:275534836:1571430499540:b93557f4

@matsko matsko closed this in 1799f62 Oct 18, 2019
AndrusGerman pushed a commit to AndrusGerman/angular that referenced this pull request Oct 22, 2019
@crisbeto @AndrusGerman
refactor(core): deprecate entryComponents (angular#33205)
2f4f9f6 
With Ivy the `entryComponents` array isn't necessary anymore. These changes mark it as deprecated so that it can be removed in a future version.

PR Close angular#33205
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@crisbeto @mary-poppins @JoostK @matsko @IgorMinar @kara @googlebot