Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use http caching on windows CI runs #33238

Closed
wants to merge 1 commit into from
Closed

build: use http caching on windows CI runs #33238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .circleci/bazel.windows.rc
View file
Open in desktop
Expand Up @@ -9,3 +9,9 @@ import %workspace%/.circleci/bazel.common.rc
# Save downloaded repositories in a location that can be cached by CircleCI. This helps us
# speeding up the analysis time significantly with Bazel managed node dependencies on the CI.
build --repository_cache=C:/Users/circleci/bazel_repository_cache

# All windows jobs run on master and should use http caching
build --config=remote-http-caching
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change makes them fast enough, we should be able to run them on PRs too. How do we ensure cache writes only happen on master?


# TODO(josephperrott): remove after #33109 lands
build --google_default_credentials
5 changes: 5 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -172,6 +172,11 @@ commands:
description: Set up CircleCI bazel configuration on Windows
steps:
- run: copy .circleci\bazel.windows.rc $env:USERPROFILE\.bazelrc
- run: mkdir %APPDATA%\gcloud
# We need ensure that the same default digest is used for encoding and decoding
# with openssl. Openssl versions might have different default digests which can
# cause decryption failures based on the openssl version. https://stackoverflow.com/a/39641378/4317734
- run: openssl aes-256-cbc -d -in .circleci/gcp_token -md md5 -k "$CI_REPO_NAME" -out %APPDATA%/gcloud/application_default_credentials.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional Nit: add a small comment saying that this file is the stored in the default location that will be picked up by Bazel then


setup_bazel_rbe:
description: Setup bazel RBE remote execution
Expand Down