-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs-infra): improve focus styles in topnav and footer #33255
Conversation
You can preview 735eefd at https://pr33255-735eefd.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sjtrimble - good to see you back to work.
When I look at the last preview URL, it doesn't look the same as your "new behaviour" animations.
Are they out of date?
Apart from that the focussing looks much better than before.
Also, perhaps out of range for this PR, but it is weird that if the browser is the same width as in your example animations, focussing the search box actually make it go smaller. Can we fix that?
@petebacondarwin Heya! Weird, to me the preview URL and the GIF look the same. What is different? That is super weird about the search box! I'll open an issue for it. It seems to happen in a smaller screen size. |
@gkalpak here's the PR that needs your help with getting |
@sjtrimble, let's fix the focus styles on this PR and I'll create a separate one for highlighting active tobbar nav links. EDIT: Created #33351. As Pete mentioned, the styling on the preview looks different than your gifs 😁 The main (undesirable) differences I see are:
Does it look different on your machine? |
@gkalpak Super strange .. yeah, it doesn't look like that on my machine. I'm using a Chrome browser on my Mac both on my local version and in the PR preview link 🤔 I checked on Safari and it changes the color there for some of the outlines which is also strange .. |
@gkalpak I have a fix for this ready. I will discuss it with you offline. |
@sjtrimble / @gkalpak Please see followup PR with a fix: |
735eefd
to
7b6fc99
Compare
This comment has been minimized.
This comment has been minimized.
@sjtrimble, could you take a look at my fixup commit and verify you are happy with the changes and they look OK on macOS? |
I pushed another fixup commit to fix CI. |
You can preview 9073352 at https://pr33255-9073352.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
outline-color: rgba($white, 0.8); | ||
outline-offset: 2px; | ||
// `outline-offset` is not applied on Chrome on Windows, if `outline-style` is `auto. | ||
outline-style: solid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
outline-color: $focus-outline-ondark; | ||
outline-offset: 4px; | ||
// `outline-offset` is not applied on Chrome on Windows, if `outline-style` is `auto. | ||
outline-style: solid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (and also for the social icons).
9073352
to
02ffecd
Compare
Rebased on master and explicitly set the |
You can preview 02ffecd at https://pr33255-02ffecd.ngbuilds.io/. |
(The payload size failure in |
02ffecd
to
a088d00
Compare
You can preview a088d00 at https://pr33255-a088d00.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #33239
Improved focus styles for topnav and footer including visible color.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Topnav:
Footer:
Issue Number: #33239
What is the new behavior?
Topnav:
Footer:
Does this PR introduce a breaking change?