feat(ivy): give shim generation its own compiler options #33256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
approved these changes
Oct 18, 2019
As a hack to get the Ivy compiler ngtsc off the ground, the existing 'allowEmptyCodegenFiles' option was used to control generation of ngfactory and ngsummary shims during compilation. This option was selected since it's enabled in google3 but never enabled in external projects. As ngtsc is now mature and the role shims play in compilation is now better understood across the ecosystem, this commit introduces two new compiler options to control shim generation: * generateNgFactoryShims controls the generation of .ngfactory shims. * generateNgSummaryShims controls the generation of .ngsummary shims. The 'allowEmptyCodegenFiles' option is still honored if either of the above flags are not set explicitly.
alxhub
force-pushed
the
ngtsc/shim-flags
branch
from
78b5cc4
to
84c4ed4
Compare
alxhub
added
action: merge
AndrusGerman
pushed a commit
to AndrusGerman/angular
that referenced
this pull request
Oct 22, 2019
As a hack to get the Ivy compiler ngtsc off the ground, the existing 'allowEmptyCodegenFiles' option was used to control generation of ngfactory and ngsummary shims during compilation. This option was selected since it's enabled in google3 but never enabled in external projects. As ngtsc is now mature and the role shims play in compilation is now better understood across the ecosystem, this commit introduces two new compiler options to control shim generation: * generateNgFactoryShims controls the generation of .ngfactory shims. * generateNgSummaryShims controls the generation of .ngsummary shims. The 'allowEmptyCodegenFiles' option is still honored if either of the above flags are not set explicitly. PR Close angular#33256
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a hack to get the Ivy compiler ngtsc off the ground, the existing
'allowEmptyCodegenFiles' option was used to control generation of ngfactory
and ngsummary shims during compilation. This option was selected since it's
enabled in google3 but never enabled in external projects.
As ngtsc is now mature and the role shims play in compilation is now better
understood across the ecosystem, this commit introduces two new compiler
options to control shim generation:
The 'allowEmptyCodegenFiles' option is still honored if either of the above
flags are not set explicitly.