refactor(core): better error message for undecorated-classes-with-di migration #33315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
area: core
rbuzzibarrios
approved these changes
Oct 22, 2019
|
@devversion Can you rebase? |
kara
added
action: cleanup
…migration Currently if one of the project targets could not be analyzed due to AOT compiler program failures, we gracefully proceed with the migration. This is expected, but we should not print a message at the end of the migration that the migration was _successful_. The migration was only done partially, hence it's potentially incomplete and we should make it clear that once the failures are resolved, the migration should be re-run.
devversion
force-pushed
the
refactor/core-undecorated-classes-with-di-better-error-message
branch
from
338f571
to
18e5bad
Compare
devversion
added
action: merge
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
removed
the
action: presubmit
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…migration (angular#33315) Currently if one of the project targets could not be analyzed due to AOT compiler program failures, we gracefully proceed with the migration. This is expected, but we should not print a message at the end of the migration that the migration was _successful_. The migration was only done partially, hence it's potentially incomplete and we should make it clear that once the failures are resolved, the migration should be re-run. PR Close angular#33315
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…migration (angular#33315) Currently if one of the project targets could not be analyzed due to AOT compiler program failures, we gracefully proceed with the migration. This is expected, but we should not print a message at the end of the migration that the migration was _successful_. The migration was only done partially, hence it's potentially incomplete and we should make it clear that once the failures are resolved, the migration should be re-run. PR Close angular#33315
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one of the project targets could not be analyzed
due to AOT compiler program failures, we gracefully proceed
with the migration. This is expected, but we should not
print a message at the end of the migration that the migration
was successful. The migration was only done partially, hence
the migration is potentially incomplete and we should make it clear that once
the failures are resolved, the migration should be re-run.