Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bazel): add missing comment about JS providers to ng_module.bzl #33332

Closed
wants to merge 1 commit into from
Closed

refactor(bazel): add missing comment about JS providers to ng_module.bzl #33332

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Contributor

No description provided.

@gregmagolan gregmagolan requested a review from a team as a code owner October 22, 2019 20:50
@gregmagolan gregmagolan added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Oct 22, 2019
@ngbot ngbot bot added this to the needsTriage milestone Oct 22, 2019
@gregmagolan gregmagolan added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 24, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2019
@gregmagolan
Copy link
Contributor Author

@caretaker Just a comments PR but looks like still requires a g3sync. Assistance needed. Thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gregmagolan @alexeagle @googlebot