Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): fined tune micro benchmark parameters #33341

Closed
wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Oct 23, 2019

Decrease MIN_SAMPLE_DURATION to make it more likely that we cane fit into single time slice.
Increase MIN_SAMPLE_COUNT_NO_IMPROVEMENT to make it more likely to find the best

Decrease `MIN_SAMPLE_DURATION` to make it more likely that we cane fit into single time slice.
Increase `MIN_SAMPLE_COUNT_NO_IMPROVEMENT` to make it more likely to find the best
@mhevery mhevery requested a review from a team as a code owner October 23, 2019 03:25
@shedinnmarble
Copy link

How do you prove that your number change has performance improvement? what's the difference?

@mhevery
Copy link
Contributor Author

mhevery commented Oct 23, 2019

How do you prove that your number change has performance improvement? what's the difference?

this is what we used for perf testing. We run the same benchmark over and see if the variation in results improves.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 23, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants