Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): add links to remaining migration guides #33385

Closed
wants to merge 1 commit into from
Closed

refactor(core): add links to remaining migration guides #33385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/schematics/migrations/module-with-providers/index.ts
View file
Open in desktop
Expand Up @@ -30,6 +30,10 @@ export default function(): Rule {
const failures: string[] = [];

ctx.logger.info('------ ModuleWithProviders migration ------');
ctx.logger.info('In Angular 9, the ModuleWithProviders type without a ');
ctx.logger.info('generic has been deprecated. This migration adds the ');
ctx.logger.info('generic where it is missing. See more info here:');
ctx.logger.info('https://v9.angular.io/guide/migration-module-with-providers');

if (!allPaths.length) {
throw new SchematicsException(
Expand Down
5 changes: 5 additions & 0 deletions packages/core/schematics/migrations/postinstall-ngcc/index.ts
View file
Open in desktop
Expand Up @@ -17,6 +17,11 @@ import {appendPropertyInAstObject, findPropertyInAstObject, insertPropertyInAstO
*/
export default function(): Rule {
return (tree: Tree, context: SchematicContext) => {
context.logger.info('------ ngcc postinstall migration ------');
context.logger.info('This migration adds an ngcc invocation to npm/yarn\'s ');
context.logger.info('postinstall script. See more info here: ');
context.logger.info('https://v9.angular.io/guide/migration-ngcc');

addPackageJsonScript(
tree, 'postinstall',
'ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points');
Expand Down