refactor(language-service): Simplify ExpressionVisitor in completions.ts #33391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
This commit simplifies the logic of `ExpressionVisitor` in `completions.ts`. Specifically, 1. helper functions `uniqueByName` and `lowerName` are removed. 2. Clean up the logic in visitElement() 3. Reorder constructor params 4. Add methods `addAttributeValuesToCompletions`, `addKeysToCompletions`, and `addSymbolsToCompletions`.
kyliau
force-pushed
the
expression-visitor
branch
from
23a6f0d
to
25827ed
Compare
ayazhafiz
approved these changes
Oct 26, 2019
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
….ts (angular#33391) This commit simplifies the logic of `ExpressionVisitor` in `completions.ts`. Specifically, 1. helper functions `uniqueByName` and `lowerName` are removed. 2. Clean up the logic in visitElement() 3. Reorder constructor params 4. Add methods `addAttributeValuesToCompletions`, `addKeysToCompletions`, and `addSymbolsToCompletions`. PR Close angular#33391
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
….ts (angular#33391) This commit simplifies the logic of `ExpressionVisitor` in `completions.ts`. Specifically, 1. helper functions `uniqueByName` and `lowerName` are removed. 2. Clean up the logic in visitElement() 3. Reorder constructor params 4. Add methods `addAttributeValuesToCompletions`, `addKeysToCompletions`, and `addSymbolsToCompletions`. PR Close angular#33391
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the logic of
ExpressionVisitorincompletions.ts.Specifically,
uniqueByNameandlowerNameare removed.visitElement()addAttributeValuesToCompletions,addKeysToCompletions, andaddSymbolsToCompletions.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information