ci: re-enable material unit tests job #33530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
ci/re-enable-material-unit-tests
branch
2 times, most recently
from
1d80fee
to
9430699
Compare
The Material units tests job has been disabled with the typescript upgrade PR since the components repository was still on an old TypeScript version (due to cyclic dependencies between the framework and components repository). Since the components repository has been updated to `9.0.0-next.15` and now uses the compatible TypeScript version, we can re-enable ds Related to this change, we need to ignore the `package.json` engines when installing the dependencies of the components repo. This is because the components repo already updated to NodeJS v12 and Yarn v1.19.1. This is not the case for the CI setup of framework. For now, since we don't want to change the dev setup (as it slows down development), we temporarily disable the engines. Additionally, the material unit tests job now depends on the actual release packages (not on the ngtsc compiled ones). This is because the components repo setup relies on NGCC being run. This is also helpful for validating ngcc against the framework packages.
devversion
force-pushed
the
ci/re-enable-material-unit-tests
branch
from
9430699
to
995d1dc
Compare
devversion
added
area: build & ci
filipesilva
approved these changes
Nov 1, 2019
devversion
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Nov 1, 2019
The Material units tests job has been disabled with the typescript upgrade PR since the components repository was still on an old TypeScript version (due to cyclic dependencies between the framework and components repository). Since the components repository has been updated to `9.0.0-next.15` and now uses the compatible TypeScript version, we can re-enable ds Related to this change, we need to ignore the `package.json` engines when installing the dependencies of the components repo. This is because the components repo already updated to NodeJS v12 and Yarn v1.19.1. This is not the case for the CI setup of framework. For now, since we don't want to change the dev setup (as it slows down development), we temporarily disable the engines. Additionally, the material unit tests job now depends on the actual release packages (not on the ngtsc compiled ones). This is because the components repo setup relies on NGCC being run. This is also helpful for validating ngcc against the framework packages. PR Close #33530
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
The Material units tests job has been disabled with the typescript upgrade PR since the components repository was still on an old TypeScript version (due to cyclic dependencies between the framework and components repository). Since the components repository has been updated to `9.0.0-next.15` and now uses the compatible TypeScript version, we can re-enable ds Related to this change, we need to ignore the `package.json` engines when installing the dependencies of the components repo. This is because the components repo already updated to NodeJS v12 and Yarn v1.19.1. This is not the case for the CI setup of framework. For now, since we don't want to change the dev setup (as it slows down development), we temporarily disable the engines. Additionally, the material unit tests job now depends on the actual release packages (not on the ngtsc compiled ones). This is because the components repo setup relies on NGCC being run. This is also helpful for validating ngcc against the framework packages. PR Close angular#33530
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
The Material units tests job has been disabled with the typescript upgrade PR since the components repository was still on an old TypeScript version (due to cyclic dependencies between the framework and components repository). Since the components repository has been updated to `9.0.0-next.15` and now uses the compatible TypeScript version, we can re-enable ds Related to this change, we need to ignore the `package.json` engines when installing the dependencies of the components repo. This is because the components repo already updated to NodeJS v12 and Yarn v1.19.1. This is not the case for the CI setup of framework. For now, since we don't want to change the dev setup (as it slows down development), we temporarily disable the engines. Additionally, the material unit tests job now depends on the actual release packages (not on the ngtsc compiled ones). This is because the components repo setup relies on NGCC being run. This is also helpful for validating ngcc against the framework packages. PR Close angular#33530
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Material units tests job has been disabled with the typescript upgrade
PR since the components repository was still on an old TypeScript version
(due to cyclic dependencies between the framework and components repository).
Since the components repository has been updated to
9.0.0-next.15and nowuses the compatible TypeScript version, we can re-enable the job.
Related to this change, we need to ignore the
package.jsonengines when installingthe dependencies of the components repo. This is because the components repo already
updated to NodeJS v12 and Yarn v1.19.1. This is not the case for the CI setup of
framework. For now, since we don't want to change the dev setup (as it slows down development
if everyone needs to update NodeJS and Yarn), we temporarily disable the engines.
Additionally, the material unit tests job now depends on the actual release packages
(not on the ngtsc compiled ones). This is because the components repo setup relies
on NGCC being run. This is also helpful for validating ngcc against the framework packages.