Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify status of sample app in stackblitz #33574

Closed
wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

https://angular.io/start Get-started guide does not make it clear that the sample app is a ready-made illustrative teaching app, not the generic app you get from the StackBlitz "Create Angular App" button.

Issue Number: #33213

What is the new behavior?

Clarifies status of teaching app, mentions availability of generic app builder, and compares StackBlitz as a learning environment to CLI as a more advanced development tool.

Does this PR introduce a breaking change?

  • Yes
  • No

@jbogarthyde jbogarthyde requested a review from a team as a code owner November 4, 2019 16:40
@jbogarthyde jbogarthyde self-assigned this Nov 4, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 4, 2019
@mary-poppins
Copy link

You can preview 196885c at https://pr33574-196885c.ngbuilds.io/.

@jbogarthyde jbogarthyde changed the title docs: clarify status of sample app in stackblitz Clarify status of sample app in stackblitz Nov 4, 2019
@mary-poppins
Copy link

You can preview 48a27ad at https://pr33574-48a27ad.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a2d4c63 at https://pr33574-a2d4c63.ngbuilds.io/.

@jbogarthyde jbogarthyde added this to In Progress in docs Nov 4, 2019
@jbogarthyde jbogarthyde moved this from In Progress to In Review in docs Nov 5, 2019
@mary-poppins
Copy link

You can preview 94d93f0 at https://pr33574-94d93f0.ngbuilds.io/.

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mary-poppins
Copy link

You can preview cc5ab0b at https://pr33574-cc5ab0b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9625f36 at https://pr33574-9625f36.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6c5365e at https://pr33574-6c5365e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2310003 at https://pr33574-2310003.ngbuilds.io/.

@jbogarthyde jbogarthyde removed the request for review from gkalpak November 6, 2019 18:23
@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2019
@jbogarthyde jbogarthyde moved this from In Review to Waiting for Merge in docs Nov 6, 2019
@mary-poppins
Copy link

You can preview 0a9cc4c at https://pr33574-0a9cc4c.ngbuilds.io/.

atscott pushed a commit that referenced this pull request Nov 6, 2019
@atscott atscott closed this in 2a4061a Nov 6, 2019
@jbogarthyde jbogarthyde moved this from Waiting for Merge to Done in docs Nov 6, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants