build: add ngJitMode to ng_rollup_bundle terser config #33773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
from
768224c
to
13b1a24
Compare
IgorMinar
reviewed
Nov 12, 2019
| { | ||
| "compress": { | ||
| "global_defs": {"ngDevMode": false, "ngI18nClosureMode": false, "ngJitMode": false}, | ||
| "keep_fnames": "bazel_no_debug", |
There was a problem hiding this comment.
what is "bazel_no_debug"? where does it come from? seems odd...
There was a problem hiding this comment.
Its part of the terser_minified rule.
If you use the magic strings "bazel_debug" or "bazel_no_debug", these will be replaced with true and false respecting the value of the debug attribute or the --define=DEBUG=1 bazel flag.
There was a problem hiding this comment.
Naming is a little odd perhaps
There was a problem hiding this comment.
It changes the configuration based on the debug attribute here: _terser_minified(name = name + ".min_debug", src = name, debug = True, visibility = visibility)
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
from
c54e0aa
to
a52fea9
Compare
kara
added
the
area: build & ci
gregmagolan
added
the
area: bazel
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
2 times, most recently
from
3b029d5
to
01eb4a5
Compare
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
from
01eb4a5
to
547ede1
Compare
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
2 times, most recently
from
bbb3a25
to
f251057
Compare
gregmagolan
added
the
target: patch
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
2 times, most recently
from
78f5d7e
to
de8c34e
Compare
This adds a `tools/ng_rollup_bundle/terser_config.json` file to override the default terser_minified config provided by the rule. After this change, the layer violation in rules_nodejs can be fixed by removing `"global_defs": {"ngDevMode": false, "ngI18nClosureMode": false},` from `terser_config.default.json` in rules_nodejs.
Change requested by Alex Rickabaugh in bazelbuild/rules_nodejs#1338.
gregmagolan
force-pushed
the
ng_rollup_bundle_ng_jit_mode
branch
from
de8c34e
to
5bfe850
Compare
alxhub
approved these changes
Nov 15, 2019
IgorMinar
approved these changes
Nov 15, 2019
alxhub
pushed a commit
that referenced
this pull request
Nov 15, 2019
This adds a `tools/ng_rollup_bundle/terser_config.json` file to override the default terser_minified config provided by the rule. After this change, the layer violation in rules_nodejs can be fixed by removing `"global_defs": {"ngDevMode": false, "ngI18nClosureMode": false},` from `terser_config.default.json` in rules_nodejs.
Change requested by Alex Rickabaugh in bazelbuild/rules_nodejs#1338.
PR Close #33773
alxhub
added a commit
that referenced
this pull request
Nov 16, 2019
This reverts commit c89eed5. Reason: fails on Windows CI
alxhub
added a commit
that referenced
this pull request
Nov 16, 2019
This reverts commit c89eed5. Reason: fails on Windows CI
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
tools/ng_rollup_bundle/terser_config.jsonfile addingngJitModeand overriding the default terser_minified config provided by the rule.Change requested by @alxhub in bazelbuild/rules_nodejs#1338.
After this change, the layer violation in rules_nodejs can be fixed by removing
"global_defs": {"ngDevMode": false, "ngI18nClosureMode": false},fromterser_config.default.jsonin rules_nodejs.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information