Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): avoid cyclical dependency in imports #33831

Closed
wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 14, 2019

This commit moves the setLContainerActiveIndex and getLContainerActiveIndex functions used in a few files to a common util/view_util.ts lib to avoid cyclical dependency while importing instructions/container.ts where these functions located originally.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
This commit moves the `setLContainerActiveIndex` and `getLContainerActiveIndex` functions used in a few files to a common `util/view_util.ts` lib to avoid cyclical dependency while importing `instructions/container.ts` where these functions located originally.
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor Author

AndrewKushnir commented Nov 14, 2019

@AndrewKushnir AndrewKushnir marked this pull request as ready for review Nov 14, 2019
@AndrewKushnir AndrewKushnir requested a review from angular/fw-core as a code owner Nov 14, 2019
@kara
kara approved these changes Nov 14, 2019
Copy link
Contributor

kara left a comment

LGTM

alxhub added a commit that referenced this pull request Nov 14, 2019
This commit moves the `setLContainerActiveIndex` and `getLContainerActiveIndex` functions used in a few files to a common `util/view_util.ts` lib to avoid cyclical dependency while importing `instructions/container.ts` where these functions located originally.

PR Close #33831
@alxhub alxhub closed this in 96c9ccc Nov 14, 2019
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Nov 15, 2019
This commit moves the `setLContainerActiveIndex` and `getLContainerActiveIndex` functions used in a few files to a common `util/view_util.ts` lib to avoid cyclical dependency while importing `instructions/container.ts` where these functions located originally.

PR Close angular#33831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.