fix(common): reflect input type in context #33997

crisbeto · 2019-11-22T21:45:29Z

Fixes NgForOf not reflecting the type of its input in the NgForOfContext. Also fixes NgIf which was typed to any.

Fixes #33527.
Fixes #31556.

IgorMinar · 2019-11-26T06:41:22Z

presubmit
ivy presubmit

IgorMinar

can you please split this into two commits and document each change and what is the user-facing fix/impact because when users read about this change in the changelog they will not have any idea about what this does, or mean to them.

I'm assuming that this is a fix for #33527. Can you please state that in the commit message?

Lastly, any chance we we can add some tests for this? I'm assuming that we currently don't have any good infra to test typechecking changes like this unless we write a ngtsc specific test. Is that right?

I've kicked off a presubmit for this change in the meantime to make sure that there are no surprises.

IgorMinar · 2019-11-26T06:47:33Z

also, this should target the 9.0.x branch as well because otherwise we won't be able to roll this out until v10. (I updated the target label)

JoostK

Regarding tests, I think the most valuable way would still be ngtsc's template type checking tests. I feel this way because those tests exercise real Angular templates.

As an alternative, a test could mimic the code that the type checker generates, as to assert that type inference works as expected. Such tests however are most appropriate to be run using https://github.com/microsoft/dtslint, which we don't currently have anywhere AFAIK. Also, I would consider them brittle as there's no guarantee that they are accurate, hence my preference for actual ngtsc template type checking tests.

packages/common/src/directives/ng_for_of.ts

packages/common/src/directives/ng_if.ts

crisbeto · 2019-11-26T20:01:44Z

I've addressed the feedback. Can you take another look @JoostK @IgorMinar?

JoostK

I would love to see template type checker tests. If you need help with that, please let me know.

JoostK · 2019-11-27T20:11:01Z

packages/common/src/directives/ng_if.ts

+  private _thenTemplateRef: TemplateRef<NgIfContext<T>> = null !;
+  private _elseTemplateRef: TemplateRef<NgIfContext<T>> = null !;
+  private _thenViewRef: EmbeddedViewRef<NgIfContext<T>> = null !;
+  private _elseViewRef: EmbeddedViewRef<NgIfContext<T>> = null !;


All these private fields can keep the | null, as it keeps the implementation safe against nulls.

IgorMinar

fyi: g3 is looking good. @crisbeto can you please address Joost's feedback?

crisbeto · 2019-11-27T22:21:20Z

I have all the feedback addressed locally, but it uncovered some issues with the new signatures. I'll pair up with Joost tomorrow.

Fixes `NgForOf` not reflecting the type of its input in the `NgForOfContext`.

crisbeto · 2019-11-28T19:04:31Z

All the issues and feedback should addressed now. Thank you for the help with the tests @JoostK!

JoostK

In the NgIf commit, could you include a fixes note for #31556?

packages/common/src/directives/ng_if.ts

Fixes the content of `NgIf` being typed to any. Fixes angular#31556.

crisbeto · 2019-11-29T22:11:51Z

Done.

addressed

Fixes `NgForOf` not reflecting the type of its input in the `NgForOfContext`. PR Close #33997

Fixes the content of `NgIf` being typed to any. Fixes #31556. PR Close #33997

This is a follow-up to angular#33997 where some new generic parameters were added without defaults which is technically a breaking change. These changes add the defaults.

This is a follow-up to #33997 where some new generic parameters were added without defaults which is technically a breaking change. These changes add the defaults. PR Close #34206

Splaktar · 2019-12-17T01:52:46Z

It seems like there should be a test for how this typing behaves with *ngIf="something | async; let thing". In that case, the behavior here doesn't seem to align with one of the most common use cases of *ngIf.

angular-automatic-lock-bot · 2020-01-17T16:04:21Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 22, 2019

crisbeto force-pushed the FW-1738/ngfor-input-type branch 2 times, most recently from 4d4e404 to adf9934 Compare November 22, 2019 22:02

crisbeto added area: common Issues related to APIs in the @angular/common package action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Nov 22, 2019

ngbot bot modified the milestone: needsTriage Nov 22, 2019

crisbeto marked this pull request as ready for review November 22, 2019 22:23

crisbeto requested review from a team as code owners November 22, 2019 22:23

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 26, 2019

IgorMinar suggested changes Nov 26, 2019

View reviewed changes

IgorMinar added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Nov 26, 2019

JoostK requested changes Nov 26, 2019

View reviewed changes

packages/common/src/directives/ng_for_of.ts Show resolved Hide resolved

packages/common/src/directives/ng_if.ts Show resolved Hide resolved

packages/common/src/directives/ng_if.ts Outdated Show resolved Hide resolved

crisbeto force-pushed the FW-1738/ngfor-input-type branch from adf9934 to 42c316d Compare November 26, 2019 19:58

crisbeto removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 26, 2019

crisbeto force-pushed the FW-1738/ngfor-input-type branch from 42c316d to df1e844 Compare November 26, 2019 20:06

JoostK previously requested changes Nov 27, 2019

View reviewed changes

IgorMinar approved these changes Nov 27, 2019

View reviewed changes

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 27, 2019

fix(common): reflect input type in NgForOf context

de4840d

Fixes `NgForOf` not reflecting the type of its input in the `NgForOfContext`.

crisbeto force-pushed the FW-1738/ngfor-input-type branch from df1e844 to ac43930 Compare November 28, 2019 18:47

crisbeto requested a review from a team as a code owner November 28, 2019 18:47

crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 28, 2019

JoostK reviewed Nov 29, 2019

View reviewed changes

packages/common/src/directives/ng_if.ts Outdated Show resolved Hide resolved

fix(common): reflect input type in NgIf context

66e8ed4

Fixes the content of `NgIf` being typed to any. Fixes angular#31556.

crisbeto force-pushed the FW-1738/ngfor-input-type branch from ac43930 to 66e8ed4 Compare November 29, 2019 22:11

alxhub approved these changes Dec 2, 2019

View reviewed changes

crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 2, 2019

mhevery pushed a commit that referenced this pull request Dec 2, 2019

fix(common): reflect input type in NgForOf context (#33997)

b640d38

Fixes `NgForOf` not reflecting the type of its input in the `NgForOfContext`. PR Close #33997

mhevery pushed a commit that referenced this pull request Dec 2, 2019

fix(common): reflect input type in NgIf context (#33997)

7504543

Fixes the content of `NgIf` being typed to any. Fixes #31556. PR Close #33997

mhevery closed this in a6b6d74 Dec 2, 2019

mhevery pushed a commit that referenced this pull request Dec 2, 2019

fix(common): reflect input type in NgIf context (#33997)

02958c0

Fixes the content of `NgIf` being typed to any. Fixes #31556. PR Close #33997

JoostK mentioned this pull request Dec 3, 2019

Ivy: fullTemplateTypeCheck errors with NgIterable #33527

Closed

crisbeto mentioned this pull request Dec 3, 2019

refactor(common): add defaults to new generic parameters #34206

Closed

JoostK mentioned this pull request Dec 7, 2019

feat(ivy): support types narrowing for template context of NgIf #31568

Closed

14 tasks

Splaktar mentioned this pull request Dec 17, 2019

build: enable strictPropertyInitialization angular/material.angular.io#689

Merged

Splaktar mentioned this pull request Dec 27, 2019

ngIf with async pipe causes new template type checking errors when template variables are used in rc.5 #34572

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(common): reflect input type in context #33997

fix(common): reflect input type in context #33997

crisbeto commented Nov 22, 2019 •

edited

IgorMinar commented Nov 26, 2019

IgorMinar left a comment

IgorMinar commented Nov 26, 2019 •

edited

JoostK left a comment

crisbeto commented Nov 26, 2019

JoostK left a comment

JoostK Nov 27, 2019

IgorMinar left a comment

crisbeto commented Nov 27, 2019

crisbeto commented Nov 28, 2019

JoostK left a comment

crisbeto commented Nov 29, 2019

Splaktar commented Dec 17, 2019 •

edited

angular-automatic-lock-bot bot commented Jan 17, 2020

fix(common): reflect input type in context #33997

fix(common): reflect input type in context #33997

Conversation

crisbeto commented Nov 22, 2019 • edited

IgorMinar commented Nov 26, 2019

IgorMinar left a comment

Choose a reason for hiding this comment

IgorMinar commented Nov 26, 2019 • edited

JoostK left a comment

Choose a reason for hiding this comment

crisbeto commented Nov 26, 2019

JoostK left a comment

Choose a reason for hiding this comment

JoostK Nov 27, 2019

Choose a reason for hiding this comment

IgorMinar left a comment

Choose a reason for hiding this comment

crisbeto commented Nov 27, 2019

crisbeto commented Nov 28, 2019

JoostK left a comment

Choose a reason for hiding this comment

crisbeto commented Nov 29, 2019

Splaktar commented Dec 17, 2019 • edited

angular-automatic-lock-bot bot commented Jan 17, 2020

crisbeto commented Nov 22, 2019 •

edited

IgorMinar commented Nov 26, 2019 •

edited

Splaktar commented Dec 17, 2019 •

edited