Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small typo in DI docs #34122

Closed
wants to merge 1 commit into from
Closed

docs: small typo in DI docs #34122

wants to merge 1 commit into from

Conversation

santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented Nov 28, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@santoshyadavdev santoshyadavdev requested a review from a team as a code owner November 28, 2019 07:07
@santoshyadavdev santoshyadavdev changed the title docs: small type in DI docs docs: small typo in DI docs Nov 28, 2019
@santoshyadavdev
Copy link
Contributor Author

@kapunahelewong small doc change here.

IgorMinar
IgorMinar approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@IgorMinar IgorMinar added comp: docs action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 29, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 29, 2019
@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 29, 2019
@IgorMinar
Copy link
Contributor

merge-assistance: global approval

mhevery pushed a commit that referenced this pull request Dec 2, 2019
@santoshyadavdev @mhevery
docs: small typo in DI docs (#34122)
a5fe850 
PR Close #34122
@mhevery mhevery closed this in 0406734 Dec 2, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@santoshyadavdev @IgorMinar @googlebot