feat(core): add isPromise generic

[danranVm]

add generic to help type inference

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[petebacondarwin]

I would squash the three commits into one and use the more general refactor: make addPromise() generic commit message.

Otherwise LGTM

[mhevery]

presubmit

[matsko]

updated presubmit = https://test.corp.google.com/ui#id=OCL:299433375:BASE:299433840:1583770957489:2e3bf4af

[matsko]

@danranVm please rebase so we can see if this works with TypeScript 3.8.

[IgorMinar]

fyi: I just relabeled this PR as "master-only" since it's a "feature" that does not belong on the patch branch.

[danranVm]

@danranVm please rebase so we can see if this works with TypeScript 3.8.

@matsko done

[AndrewKushnir]

Hi @danranVm, thanks for rebasing this PR. I've noticed that there is a new comment that was added as a result of rebase (refactor: rebase code). Could you please squash commits, so there is just the first one? Thank you.

[danranVm]

@AndrewKushnir ok, it's correct now ?

[AndrewKushnir]

Hi @danranVm, thanks for updating commit messages, everything looks good now. I've started a new g3 presubmit (internal only link) and will keep you updated. Thank you.

[AndrewKushnir]

@danranVm, sorry, just noticed that the commit message refers to addPromise function, but the actual function being updated in this PR is isPromise. Also, the commit description uses refactor: namespace, when PR title says feat(core). I'd propose to update commit message to something like this (also include why this change is made):

feat(core): add `isPromise` generic

This commit adds generic to `isPromise` function to help with type inference.

Could you please update commit message?

Thank you.

[danranVm]

@AndrewKushnir updated, thanks for your review.

[AndrewKushnir]

Hi @danranVm, thanks for the updates. The commit message looks good and g3 presubmit is successful, so I'm adding the "merge" label back. I also updated the "PR target" to be master and patch, since we cut 9.1.0 RC.0 this morning and created a new patch branch for 9.1.x versions. Thank you.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}