Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): delete ɵɵelementHostAttrs instruction #34717

Merged
merged 1 commit into from Jan 14, 2020
Merged

refactor(ivy): delete ɵɵelementHostAttrs instruction #34717

merged 1 commit into from Jan 14, 2020

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jan 10, 2020 •
edited

This PR is part of sequence of work which is meant to be reviewed together:

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mhevery mhevery requested review from a team as code owners January 10, 2020 05:50
@mhevery mhevery requested a review from a team January 10, 2020 05:50
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
98edf09 
PR Close angular#34717
mhevery added a commit that referenced this pull request Jan 10, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (#34717)
d4cf385 
PR Close #34717
@kara kara added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 10, 2020
@ngbot ngbot bot modified the milestone: needsTriage Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
6f6c82e 
PR Close angular#34717
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
f0c9ed3 
PR Close angular#34717
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
319f662 
PR Close angular#34717
mhevery added a commit to mhevery/angular that referenced this pull request Jan 13, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
a98f485 
PR Close angular#34717
@mhevery mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 13, 2020
kara
kara approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some quick things below

packages/core/src/render3/interfaces/node.ts Outdated Show resolved Hide resolved
packages/core/src/render3/interfaces/node.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/shared.ts Outdated Show resolved Hide resolved
packages/core/test/acceptance/styling_spec.ts Outdated Show resolved Hide resolved
@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 13, 2020
@mhevery mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 14, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 14, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
7d7719f 
PR Close angular#34717
mhevery added a commit to mhevery/angular that referenced this pull request Jan 14, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
3f367aa 
PR Close angular#34717
@mhevery
Copy link
Contributor Author

mhevery commented Jan 14, 2020

presubmit

@mhevery mhevery merged commit 9a0067f into angular:styling Jan 14, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 21, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
093ffb4 
PR Close angular#34717
mhevery added a commit that referenced this pull request Jan 24, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (#34717)
b727303 
PR Close #34717
mhevery added a commit that referenced this pull request Jan 24, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (#34717)
da7e362 
PR Close #34717
mhevery added a commit that referenced this pull request Jan 24, 2020
@mhevery
refactor(ivy): delete ɵɵelementHostAttrs instruction (#34717)
aa7f05f 
PR Close #34717
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@mhevery @sonukapoor
refactor(ivy): delete ɵɵelementHostAttrs instruction (angular#34717)
129e925 
PR Close angular#34717
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource left review comments

@kara kara kara approved these changes

Assignees

@mhevery mhevery

Labels
cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhevery @pkozlowski-opensource @kara @googlebot