Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): delete `ɵɵelementHostAttrs` instruction #34717

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@mhevery
Copy link
Member

mhevery commented Jan 10, 2020

This PR is part of sequence of work which is meant to be reviewed together:

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mhevery mhevery requested review from angular/fw-compiler as code owners Jan 10, 2020
@googlebot googlebot added the cla: yes label Jan 10, 2020
@mhevery mhevery force-pushed the angular:styling branch from d1c7ca7 to da6c16b Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from a1a81b3 to 98edf09 Jan 10, 2020
mhevery added a commit that referenced this pull request Jan 10, 2020
@ngbot ngbot bot modified the milestone: needsTriage Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from 98edf09 to 6f6c82e Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from 6f6c82e to f0c9ed3 Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 10, 2020
@mhevery mhevery force-pushed the angular:styling branch from 65d36d6 to 142363a Jan 10, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 13, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from f0c9ed3 to a98f485 Jan 13, 2020
@kara
kara approved these changes Jan 13, 2020
Copy link
Contributor

kara left a comment

LGTM, but some quick things below

packages/core/src/render3/interfaces/node.ts Outdated Show resolved Hide resolved
packages/core/src/render3/interfaces/node.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/shared.ts Outdated Show resolved Hide resolved
packages/core/test/acceptance/styling_spec.ts Outdated Show resolved Hide resolved
mhevery added a commit to mhevery/angular that referenced this pull request Jan 14, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from a98f485 to 7d7719f Jan 14, 2020
mhevery added a commit to mhevery/angular that referenced this pull request Jan 14, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from 7d7719f to 3f367aa Jan 14, 2020
@mhevery mhevery force-pushed the mhevery:host_decl_3 branch from 3f367aa to 9a0067f Jan 14, 2020
@mhevery

This comment has been minimized.

Copy link
Member Author

mhevery commented Jan 14, 2020

@mhevery mhevery merged commit 9a0067f into angular:styling Jan 14, 2020
25 of 27 checks passed
25 of 27 checks passed
ci/angular: merge status Status "google3" is pending
google3 Googler: run g3sync presubmit 34717
Details
ci/angular: size core/todo/bundle increased by 928 bytes.
ci/circleci: aio_preview Your tests passed on CircleCI!
Details
ci/circleci: build-ivy-npm-packages Your tests passed on CircleCI!
Details
ci/circleci: build-npm-packages Your tests passed on CircleCI!
Details
ci/circleci: deploy_aio Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: legacy-misc-tests Your tests passed on CircleCI!
Details
ci/circleci: legacy-unit-tests-saucelabs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: material-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: publish_packages_as_artifacts Your tests passed on CircleCI!
Details
ci/circleci: publish_snapshot Your tests passed on CircleCI!
Details
ci/circleci: saucelabs_ivy Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test_aio Your tests passed on CircleCI!
Details
ci/circleci: test_aio_local Your tests passed on CircleCI!
Details
ci/circleci: test_aio_local_viewengine Your tests passed on CircleCI!
Details
ci/circleci: test_aio_preview Your tests passed on CircleCI!
Details
ci/circleci: test_aio_tools Your tests passed on CircleCI!
Details
ci/circleci: test_docs_examples Your tests passed on CircleCI!
Details
ci/circleci: test_docs_examples_ivy Your tests passed on CircleCI!
Details
ci/circleci: test_ivy_aot Your tests passed on CircleCI!
Details
ci/circleci: test_zonejs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
mhevery added a commit to mhevery/angular that referenced this pull request Jan 21, 2020
mhevery added a commit that referenced this pull request Jan 24, 2020
mhevery added a commit that referenced this pull request Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.