Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add amazon s3 builder package #34783

Closed
wants to merge 1 commit into from
Closed

docs: add amazon s3 builder package #34783

wants to merge 1 commit into from

Conversation

Jefiozie
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

I've added a new builder that will deploy your angular app to the Amazon Cloud S3

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Jefiozie Jefiozie requested a review from a team as a code owner January 15, 2020 06:18
@Jefiozie Jefiozie mentioned this pull request Jan 15, 2020
Closed
@ngbot ngbot bot added this to the needsTriage milestone Jan 15, 2020
@kapunahelewong kapunahelewong added effort1: hours risk: low feature Issue that requests a new feature labels Jan 16, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 16, 2020
@kapunahelewong kapunahelewong added the state: needs eng review Needs technical review and approval from engineering team label Jan 16, 2020
@kapunahelewong kapunahelewong added this to Need Assistance from Eng. in docs Jan 16, 2020
@Jefiozie
Copy link
Contributor Author

Hi, just checking if I need to do anything around this issue?
Thanks

@pullapprove pullapprove bot requested a review from mgechev January 29, 2020 20:25
@mgechev
Copy link
Member

mgechev commented Feb 1, 2020

LGTM! Thanks for putting this together!

@mgechev mgechev added action: merge The PR is ready for merge by the caretaker and removed state: needs eng review Needs technical review and approval from engineering team labels Feb 20, 2020
@Jefiozie
Copy link
Contributor Author

Hi @mgechev, is there any thing I can do to get this PR in? ☺️

@mhevery mhevery removed the request for review from a team February 24, 2020 17:08
@mhevery mhevery added the target: patch This PR is targeted for the next patch release label Feb 24, 2020
mhevery pushed a commit that referenced this pull request Feb 24, 2020
@Jefiozie @mhevery
docs: add amazon s3 builder package (#34783)
89f6b34 
PR Close #34783
@mhevery mhevery closed this in 3893799 Feb 24, 2020
@jbogarthyde jbogarthyde moved this from Need Assistance from Eng. to Done in docs Feb 25, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature risk: low target: patch This PR is targeted for the next patch release
Projects
docs
Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jefiozie @mgechev @mhevery @atscott @kapunahelewong @googlebot