New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): support @SkipSelf while injecting special DI tokens #34839
Conversation
Related to #34554. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
merge-assistance: global approval |
02651eb
to
a0832d4
Compare
@kara thanks for the review! I'd like to ask you to have a look at this PR again, since I had to update a bunch of payload limits, which I believe for the most part is an accumulation of payload size increase introduced in other commits merged to master prior to this change, see #34839 (comment). Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quick update: investigation of g3 failures revealed a couple use-cases that work incorrectly with the changes in this PR due to the |
…ementRef and ChangeDetectorRef
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
…ementRef and ChangeDetectorRef
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Closing this PR in favor of #39464. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently Ivy doesn't support adding
@SkipSelf
for some of the special DI tokens (e.g.Injector
,ViewContainerRef
,ElementRef
,ChangeDetectorRef
). These changes add support for@SkipSelf
flag and align the behavior with View Engine.Closes #34066.
Closes #34819.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?