fix(ivy): incorrectly generating shared pure function between null and object literal #35481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
35298/pure-function-null-shared
branch
3 times, most recently
from
2e2cdd1
to
5c54e91
Compare
crisbeto
added
comp: ivy
action: review
crisbeto
commented
Feb 16, 2020
| @Component({ | ||
| template: ` | ||
| <div [dir]="{foo: null}"></div> | ||
| <div [dir]="{foo: getFoo()}"></div> |
There was a problem hiding this comment.
I think this one has been an issue even before #33705, but we just never hit it.
alxhub
approved these changes
Feb 19, 2020
alxhub
requested changes
Feb 19, 2020
crisbeto
force-pushed
the
35298/pure-function-null-shared
branch
from
db86429
to
f95ca65
Compare
alxhub
approved these changes
Feb 20, 2020
…d object literal In angular#33705 we made it so that we generate pure functions for object/array literals in order to avoid having them be shared across elements/views. The problem this introduced is that further down the line the `ContantPool` uses the generated literal in order to figure out whether to share an existing factory or to create a new one. `ConstantPool` determines whether to share a factory by creating a key from the AST node and using it to look it up in the factory cache, however the key generation function didn't handle function invocations and replaced them with `null`. This means that the key for `{foo: pureFunction0(...)}` and `{foo: null}` are the same. These changes rework the logic so that instead of generating a `null` key for function invocations, we generate a variable called `<unknown>` which shouldn't be able to collide with anything. Fixes angular#35298.
…null and object literal
crisbeto
force-pushed
the
35298/pure-function-null-shared
branch
from
f95ca65
to
b87b90f
Compare
crisbeto
added
action: merge
kara
approved these changes
Feb 20, 2020
mhevery
pushed a commit
that referenced
this pull request
Feb 20, 2020
…d object literal (#35481) In #33705 we made it so that we generate pure functions for object/array literals in order to avoid having them be shared across elements/views. The problem this introduced is that further down the line the `ContantPool` uses the generated literal in order to figure out whether to share an existing factory or to create a new one. `ConstantPool` determines whether to share a factory by creating a key from the AST node and using it to look it up in the factory cache, however the key generation function didn't handle function invocations and replaced them with `null`. This means that the key for `{foo: pureFunction0(...)}` and `{foo: null}` are the same. These changes rework the logic so that instead of generating a `null` key for function invocations, we generate a variable called `<unknown>` which shouldn't be able to collide with anything. Fixes #35298. PR Close #35481
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #33705 we made it so that we generate pure functions for object/array literals in order to avoid having them be shared across elements/views. The problem this introduced is that further down the line the
ContantPooluses the generated literal in order to figure out whether to share an existing factory or to create a new one.ConstantPooldetermines whether to share a factory by creating a key from the AST node and using it to look it up in the factory cache, however the key generation function didn't handle function invocations and replaced them withnull. This means that the key for{foo: pureFunction0(...)}and{foo: null}are the same.These changes rework the logic so that instead of generating a
nullkey for function invocations, we generate a variable called<unknown>which shouldn't be able to collide with anything.Fixes #35298.