fix(animations): process shorthand margin and padding styles correctly
#35701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
added
area: animations
target: patch
matsko
force-pushed
the
optimize_animation_code
branch
5 times, most recently
from
c4ba8f5
to
55a9fb4
Compare
kara
approved these changes
Feb 28, 2020
Comment on lines
+246
to
+248
| * style value for the element. Firefox doesn't support reading the shorthand | ||
| * forms of margin/padding and for this reason this function needs to account | ||
| * for that. |
There was a problem hiding this comment.
Thanks for documenting this 👍
| if (value.length === 0 && (prop === 'margin' || prop === 'padding')) { | ||
| // reconstruct the padding/margin value as `top right bottom left` | ||
| const propTop = (prop + 'Top') as 'marginTop' | 'paddingTop'; | ||
| const propRight = (prop + 'Right') as 'marginRight' | 'paddingLeft'; |
There was a problem hiding this comment.
Suggested change
| const propRight = (prop + 'Right') as 'marginRight' | 'paddingLeft'; | |
| const propRight = (prop + 'Right') as 'marginRight' | 'paddingRight'; |
kara
added
the
action: cleanup
…ectly Prior to this patch, the `margin` and `padding` properties were not detected properly by Firefox due to them being shorthand properties. This patch ensures that both `margin` and `padding` are converted read as `top right bottom left` in the event that the shorthand property detection fails for auto-styling in Angular animations. Fix angular#35463 (FW-1886)
matsko
force-pushed
the
optimize_animation_code
branch
from
55a9fb4
to
b9ad30f
Compare
matsko
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Mar 2, 2020
…ectly (#35701) Prior to this patch, the `margin` and `padding` properties were not detected properly by Firefox due to them being shorthand properties. This patch ensures that both `margin` and `padding` are converted read as `top right bottom left` in the event that the shorthand property detection fails for auto-styling in Angular animations. Fix #35463 (FW-1886) PR Close #35701
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 4, 2020
…les correctly (angular#35701)" This reverts commit 35c9f0d, breaks internal tests
atscott
added a commit
that referenced
this pull request
Mar 4, 2020
atscott
added a commit
that referenced
this pull request
Mar 4, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the
marginandpaddingproperties were notdetected properly by Firefox due to them being shorthand properties.
This patch ensures that both
marginandpaddingare convertedread as
top right bottom leftin the event that the shorthandproperty detection fails for auto-styling in Angular animations.
Fix #35463 (FW-1886)