Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix flakiness in integration/bazel by disabling symlinked_node… #35804

Closed
wants to merge 1 commit into from
Closed

build: fix flakiness in integration/bazel by disabling symlinked_node… #35804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions integration/bazel/WORKSPACE
View file
Open in desktop
@@ -1,7 +1,4 @@
workspace(
name = "bazel_integration_test",
managed_directories = {"@npm": ["node_modules"]},
)
workspace(name = "bazel_integration_test")

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

Expand Down Expand Up @@ -57,6 +54,11 @@ node_repositories(
yarn_install(
name = "npm",
package_json = "//:package.json",
# Turn off symlink_node_modules here as it causes flakiness with missing
# files in node_modules.
# TODO: track down the root cause of the flakiness; current suspect is that
# it is an issue with managed_directories when resources are limited
symlink_node_modules = False,
yarn_lock = "//:yarn.lock",
)

Expand Down