Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): do not use manifest paths for generated imports within compilation unit #35841

Commits on Mar 4, 2020

  1. Configuration menu
    Copy the full SHA
    8d2b43e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. fix(bazel): do not use manifest paths for generated imports within co…

    …mpilation unit
    
    Currently, the `ng_module` rule incorrectly uses manifest paths for
    generated imports from the Angular compiler.
    
    This breaks packaging as prodmode output (i.e. `esnext`) is copied in
    various targets (`es5` and `es2015`) to the npm package output.
    
    e.g. imports are generated like:
    
    _node_modules/my-pkg/es2015/imports/public-api.js_
    ```ts
    import * as i1 from "angular/packages/bazel/test/ng_package/example/imports/second";
    ```
    
    while it should be actually:
    
    ```ts
    import * as i1 from "./second";
    ```
    
    The imports can, and should be relative so that the files are
    self-contained and do not rely on custom module resolution.
    devversion committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    36a09a2 View commit details
    Browse the repository at this point in the history