Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(bazel): transform generated shims (in Ivy) with tsickle (#35848)" #35970

Closed
wants to merge 1 commit into from
Closed

Revert "feat(bazel): transform generated shims (in Ivy) with tsickle (#35848)" #35970

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Mar 9, 2020

This reverts commit 9ff9a07.

@matsko matsko added the target: major This PR is targeted for the next major release label Mar 9, 2020
@matsko matsko marked this pull request as ready for review March 9, 2020 19:49
@pullapprove pullapprove bot requested a review from kara March 9, 2020 19:49
@matsko matsko requested a review from alxhub March 9, 2020 19:56
AndrewKushnir
AndrewKushnir approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Matias, could you plz mention the reason for the revert in a PR description (for history)?

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Mar 9, 2020
@matsko matsko closed this in 15482e7 Mar 9, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@kara kara Awaiting requested review from kara

@alxhub alxhub Awaiting requested review from alxhub

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matsko @AndrewKushnir @googlebot