Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(core): Add benchpress test for transplanted view change detection #36001

Closed
wants to merge 2 commits into from
Closed

test(core): Add benchpress test for transplanted view change detection #36001

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 10, 2020

Adds a performance benchmark for transplanted views views (those which are declared in one component and inserted into another).

@pullapprove pullapprove bot requested a review from gkalpak March 10, 2020 22:56
@atscott atscott added area: core Issues related to the framework runtime area: testing Issues related to Angular testing features, such as TestBed target: patch This PR is targeted for the next patch release labels Mar 10, 2020
@ngbot ngbot bot modified the milestone: needsTriage Mar 10, 2020
@atscott atscott force-pushed the benchpress branch 2 times, most recently from 2cd10b9 to 45ceb38 Compare March 10, 2020 23:17
gkalpak
gkalpak approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message typo: views views --> views plus a couple of minor questions/suggestions.
Otherwise lgtm ✨

modules/benchmarks/src/change_detection/change_detection.e2e-spec.ts Outdated Show resolved Hide resolved
modules/benchmarks/src/change_detection/util.ts Outdated Show resolved Hide resolved
modules/benchmarks/src/change_detection/util.ts Outdated Show resolved Hide resolved
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 11, 2020
@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 11, 2020
@atscott atscott requested a review from mhevery March 11, 2020 15:32
mhevery
mhevery approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up

modules/benchmarks/src/change_detection/transplanted_views/transplanted_views.ts Outdated Show resolved Hide resolved
modules/benchmarks/src/change_detection/transplanted_views/transplanted_views.ts Outdated Show resolved Hide resolved
modules/benchmarks/src/change_detection/transplanted_views/transplanted_views.ts Outdated Show resolved Hide resolved
modules/benchmarks/src/change_detection/transplanted_views/transplanted_views.ts Show resolved Hide resolved
@mhevery mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 11, 2020
@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 11, 2020
@atscott
test(core): Add benchpress test for transplanted view change detection
e0344c1 
Adds a performance benchmark for transplanted views (those which are declared in one component and inserted into another).
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 12, 2020
@atscott atscott removed the request for review from pkozlowski-opensource March 12, 2020 18:39
AndrewKushnir pushed a commit that referenced this pull request Mar 12, 2020
@atscott @AndrewKushnir
test(core): Add benchpress test for transplanted view change detection (
f699c96 
#36001)

Adds a performance benchmark for transplanted views (those which are declared in one component and inserted into another).

PR Close #36001
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: testing Issues related to Angular testing features, such as TestBed cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atscott @mhevery @gkalpak @googlebot