Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding a note on extra text interpolations and HTML tags in translations to Ivy guide #36029

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates Ivy compatibility guide with additional note on extra text interpolations and HTML tags in translations.

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: patch This PR is targeted for the next patch release comp: ivy labels Mar 11, 2020
@AndrewKushnir AndrewKushnir requested a review from kara March 11, 2020 23:22
@ngbot ngbot bot modified the milestone: needsTriage Mar 11, 2020
@AndrewKushnir AndrewKushnir requested review from petebacondarwin and removed request for kara March 11, 2020 23:24
@kara kara self-requested a review March 12, 2020 18:40
aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 12, 2020
@AndrewKushnir AndrewKushnir removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 12, 2020
@AndrewKushnir
Copy link
Contributor Author

Thanks for the review @kara and @petebacondarwin!

@kara I've updated the doc based on your comment. Could you please take another look when you get a chance?

@AndrewKushnir AndrewKushnir removed their assignment Mar 12, 2020
aio/content/guide/ivy-compatibility.md Outdated Show resolved Hide resolved
@AndrewKushnir AndrewKushnir requested a review from kara March 17, 2020 22:36
@AndrewKushnir
Copy link
Contributor Author

Thanks Kara, I've updated the text as you proposed. Could you please have a final look? Thank you.

…nslations to Ivy guide

This commit updates Ivy compatibility guide with additional note on extra text interpolations and HTML tags in translations.
@AndrewKushnir AndrewKushnir force-pushed the FW-1978_i18n_note_to_ivy_compat_guide branch from 8e0dbed to bdaad61 Compare March 17, 2020 22:37
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Mar 18, 2020
AndrewKushnir added a commit that referenced this pull request Mar 18, 2020
…nslations to Ivy guide (#36029)

This commit updates Ivy compatibility guide with additional note on extra text interpolations and HTML tags in translations.

PR Close #36029
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants