Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zone.js): UNPATCHED_EVENTS and PASSIVE_EVENTS should be string[] not boolean #36258

Closed
wants to merge 1 commit into from
Closed

fix(zone.js): UNPATCHED_EVENTS and PASSIVE_EVENTS should be string[] not boolean #36258

wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented Mar 26, 2020 •
edited

__zone_symbol__UNPATCHED_EVENTS and __zone_symbol__PASSIVE_EVENTS should be string[] type not boolean.
For example:

const config = window as ZoneGlobalConfigurations;
config.__zone_symbol__UNPATCHED_EVENTS = ['scroll'];
config.__zone_symbol__PASSIVE_EVENTS = ['scroll'];

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Thank @tonivj5 for posting the issue.

@pullapprove pullapprove bot requested a review from mhevery March 26, 2020 12:50
@JiaLiPassion
fix(zone.js): UNPATCHED_EVENTS and PASSIVE_EVENTS should be string[] …
2d71d8f 
…not boolean

__zone_symbol__UNPATCHED_EVENTS and __zone_symbol__PASSIVE_EVENTS should be string[] type not boolean.
For example:
```
const config = window as ZoneGlobalConfigurations;
config.__zone_symbol__UNPATCHED_EVENTS = ['scroll'];
config.__zone_symbol__PASSIVE_EVENTS = ['scroll'];
```
@tonivj5
Copy link

tonivj5 commented Mar 26, 2020

You're fast, boy 🚀 👀 👏

@JiaLiPassion JiaLiPassion added area: zones target: major This PR is targeted for the next major release labels Mar 26, 2020
@ngbot ngbot bot modified the milestone: needsTriage Mar 26, 2020
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2020
@mhevery
Copy link
Contributor

mhevery commented Mar 30, 2020

presubmit

@alxhub alxhub closed this in 36e927a Apr 1, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JiaLiPassion @tonivj5 @mhevery @googlebot