-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(changelog): remove unnecessary entries #36264
docs(changelog): remove unnecessary entries #36264
Conversation
Is anyone interested in this fix? @filipesilva @atscott |
Is anyone interested in this fix? @kara |
Hi @cerkiner, thank you for this PR. I'm sorry for the delay. We are working on catching up with the issues and PRs backlog. I have added the appropriate labels, including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the second commit looks good, but the first one has removals which I don't understand.
Can you please explain what key you used to determine which entries to keep and which to remove?
Also, can you please follow our commit message convention and ensure that the CI lint checks pass? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
@IgorMinar I first realised there are duplicate entries for same changes and fixes, while I am fixing the issue, I realised there are some titles with no entries. 6972401 Removes duplicate entries by keeping the earliest mention of each entry. I can apply the same changes to recent change log entries as well. |
@cerkiner would you mind squashing your changes into just two commits? docs(changelog): remove duplicate entries
Remove duplicate entries in the changelog, keeping only the earliest instance of changes that appear multiple times. docs(changelog): remove empty sections
The changelog contains some empty sections (such as `### Bug Fixes`). This change removes these empty sections. |
Remove duplicate entries in the changelog, keeping only the earliest instance of changes that appear multiple times.
The changelog contains some empty sections (such as `### Bug Fixes`). This change removes these empty sections.
3b8870f
to
379f131
Compare
@jelbourn Thank you for the copy, I used it exactly as is. I also applied the same changes to recent changelog entries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: global-approvers
The changelog contains some empty sections (such as `### Bug Fixes`). This change removes these empty sections. PR Close #36264
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Remove duplicate entries in the changelog, keeping only the earliest instance of changes that appear multiple times. PR Close angular#36264
The changelog contains some empty sections (such as `### Bug Fixes`). This change removes these empty sections. PR Close angular#36264
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Unnecessary, repeating entries in the changelog
Issue Number: N/A
What is the new behavior?
Remove unnecessary, repeating entries in the changelog
Does this PR introduce a breaking change?
Other information
The earliest mention of each entry is kept and duplicate entries mentioned in newer versions are removed.