fix(compiler-cli): resolve rootDir to absolute

[Toxicable]

PR Checklist

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

• Feature

What is the current behavior?

Issue Number: #36290

What is the new behavior?

Allows for a relative rootDir to be passed, usually via the command line which we will join to the cwd

Does this PR introduce a breaking change?

• No

[Toxicable]

Im not 100% certain this is the place to make this change so would appciate some feedback on that.

For context I'd like to land this so that we can remove the patch found here: https://github.com/bazelbuild/rules_nodejs/pull/1619/files#diff-5eb8729ae1c44d09b4ddc25c90585b9a

[JoostK]

I was curious how this is handled in tsc, and they preprocess the command line args using the internal ts.convertToOptionsWithAbsolutePaths. Maybe we can implement a similar approach, to achieve consistent handling of compiler options.

Regardless, this change would need a test. You can probably extend NgtscTestEnvironment with a method to configure additional command line args, and then pass those through in driveMain and driveDiagnostics.

[JoostK]

You should be able to only replace absoluteFrom with resolve, that resolves ^{(sorry for the pun)} the issue for me as well.

[petebacondarwin]

Actually you could replace the whole return statement with:

return rootDirs.map(rootDir => fs.resolve(cwd, rootDir);

[jbedard]

@Toxicable any update on this? I tried patching this along with the recommendation from @JoostK and it seems to be working. I could take it over if you'd like...

[Toxicable]

@jbedard Ah yeah if you wanna take this one then that's cool with me

[jbedard]

@JoostK is there an example of a test similar to what you're suggesting with NgtscTestEnvironment? Would this be testing a full run of ngtsc as opposed to testing only readConfiguration or readCommandLineAndConfiguration?

If we were to do something like convertToOptionsWithAbsolutePaths in typescript do you think that would go somewhere such as readConfiguration?

[petebacondarwin]

@jbedard - you could certainly create a simply unit test in a new file typescript_spec.ts at https://github.com/angular/angular/tree/master/packages/compiler-cli/src/ngtsc/util/test.

I would run this test using runInEachFileSystem() to provide a mock FileSystem for the tests.

I am not convinced that an e2e test is particularly needed.

[literalpie]

I'm taking a stab at this in #41359

[petebacondarwin]

Closing in favour of #41359

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}