Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix typo in PullApprove group name (server-worker --> service-worker) #36325

Closed
wants to merge 1 commit into from
Closed

build: fix typo in PullApprove group name (server-worker --> service-worker) #36325

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 30, 2020

☝️

@pullapprove pullapprove bot requested a review from IgorMinar March 30, 2020 17:14
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release refactoring Issue that involves refactoring or code-cleanup labels Mar 30, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 30, 2020
@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 2, 2020
IgorMinar
IgorMinar approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: this should have been a ci: commit as it's about ci checks and not about how we build the code.

@IgorMinar IgorMinar removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 5, 2020
alxhub pushed a commit that referenced this pull request May 6, 2020
@gkalpak @alxhub
build: fix typo in PullApprove group name (server-worker --> service-…
64453e4 
…worker) (#36325)

PR Close #36325
@alxhub alxhub closed this in 333abf1 May 6, 2020
gkalpak referenced this pull request May 14, 2020
@mhevery
fix: add aikidave as reviewer for DOCS: Marketing (#37014)
efe1713 
It makes sense that the lead technical writer should be allowed
to approve changes to DOCS: Marketing. The inspriration for this
change came to the current lead technical writer in a vision, or
perhaps it was a fugue state caused by too little caffeine. No
one knows. It's still a good idea though.

PR Close #37014
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@gkalpak @profanis
build: fix typo in PullApprove group name (server-worker --> service-…
71f260e 
…worker) (angular#36325)

PR Close angular#36325
@gkalpak gkalpak deleted the build-pullapprove-sw-typo branch October 2, 2020 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @IgorMinar @kara @googlebot