New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): attempt to recover from user errors during creation #36381
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -684,6 +684,12 @@ export interface TView { | |
* Used for directive matching, attribute bindings, local definitions and more. | ||
*/ | ||
consts: TConstants|null; | ||
|
||
/** | ||
* Indicates that there was an error before we managed to complete the first create pass of the | ||
* view. This means that the view is likely corrupted and we should try to recover it. | ||
*/ | ||
incompleteFirstPass: boolean; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking of potentially making this a counter so that we can stop trying after a certain number of attempts. I decided to keep it simple for now, but I'm open to changing it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeh, I think that keeping it simple for now is the way to go 👍 |
||
} | ||
|
||
export const enum RootContextFlags { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is mostly accumulation from other PRs? The change itself doesn't seem to merit this jump in size.