New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add commit message scope for migration changes #36390
build: add commit message scope for migration changes #36390
Conversation
OOC, why not use the proper scope (instead of |
That's a good point. I think it would be still ambiguous if we would use e.g. Additionally it would still require longer commit messages, and in the changelog, migration changes would not be grouped. I guess it would be good to have migrations show up separately in the changelog as they don't affect |
@IgorMinar Would you be able to provide some feedback on this? It's not urgent though 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM but we should announce this change and in order to enforce it we will need reviewers to look for the current scope to be applied. Changing the pullapprove settings to create a new group for migrations would make that easier.
@IgorMinar Thanks for reviewing! Yeah, we added a separate code owner group for migrations already (see here). Definitely agreed that we should announce this. I'm wondering if we could do better at enforcing these commit scopes. That might be a good thing to look into from the dev-infra side. |
This is a proposal commit that adds a separate scope for migration changes. The motiviation is that migrations aren't necessarily always affecting `@angular/core`, but are just stored in the core package for a canonical location when someone runs `ng update`. Additionally, it rather seems confusing in the changelog if migration changes are listed under `core`.
aeecf21
to
0cb37c9
Compare
This is a proposal commit that adds a separate scope for migration changes. The motiviation is that migrations aren't necessarily always affecting `@angular/core`, but are just stored in the core package for a canonical location when someone runs `ng update`. Additionally, it rather seems confusing in the changelog if migration changes are listed under `core`. PR Close #36390
This is a proposal commit that adds a separate scope for migration changes. The motiviation is that migrations aren't necessarily always affecting `@angular/core`, but are just stored in the core package for a canonical location when someone runs `ng update`. Additionally, it rather seems confusing in the changelog if migration changes are listed under `core`. PR Close angular#36390
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a proposal commit that adds a separate scope for migration changes. The motiviation is that migrations aren't necessarily always affecting `@angular/core`, but are just stored in the core package for a canonical location when someone runs `ng update`. Additionally, it rather seems confusing in the changelog if migration changes are listed under `core`. PR Close angular#36390
This is a proposal commit that adds a separate scope for migration changes.
The motivation is that migrations aren't necessarily always affecting
@angular/core
(e.g. the
move-document
migration is affecting platform-browser). Migrations are juststored in the
@angular/core
package in favor of a canonical location when someoneruns
ng update
. Additionally, it rather seems confusing that migration changes are listedunder
core
in the changelog. Long commit message titles are needed to make clear thatcommits do not affect
@angular/core
runtime logic, but just the ng update migrations.