Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): handle empty translations correctly #36499

Closed
wants to merge 2 commits into from
Closed

fix(core): handle empty translations correctly #36499

wants to merge 2 commits into from

Commits on Apr 14, 2020

  1. fix(core): handle empty translations correctly 

    In certain use-cases it's useful to have an ability to use empty strings as translations. Currently Ivy fails at runtime if empty string is used as a translation, since some parts of internal data structures are not created properly. This commit updates runtime i18n logic to handle empty translations and avoid unnecessary extra processing for such cases.

Fixes angular#36476.
    @AndrewKushnir
    AndrewKushnir committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    2cf3fa9 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(core): handle empty translations correctly

    @AndrewKushnir
    AndrewKushnir committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    512f5a8 View commit details
    Browse the repository at this point in the history