feat(docs-infra): created new widget for events page #36517

ajitsinghkaler · 2020-04-08T16:53:44Z

Earlier data in events page was hardcoded and data have to be moved manually in the table now events will automatically move between current and past events in this implementation

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Data has to be manually changed in events

Issue Number: N/A

What is the new behavior?

Data will automatically be changed in presented and upcoming events

Does this PR introduce a breaking change?

Yes
No

Other information

ajitsinghkaler · 2020-04-08T16:56:30Z

@petebacondarwin @StephenFluin @gkalpak if we can finalize the way in which the new events widget will be implemented after that I will add tests

mary-poppins · 2020-04-12T09:26:31Z

You can preview bf62aab at https://pr36517-bf62aab.ngbuilds.io/.
You can preview 3be5189 at https://pr36517-3be5189.ngbuilds.io/.

gkalpak

I've wanted this for a long time, thx, @ajitsinghkaler 🎉
I've left a first round of comments.

aio/src/app/custom-elements/events/events.component.html

aio/content/marketing/events.json

aio/src/app/custom-elements/events/events.component.ts

aio/content/marketing/events.json

aio/src/app/custom-elements/events/events.service.ts

mary-poppins · 2020-04-12T12:51:05Z

You can preview 5332c91 at https://pr36517-5332c91.ngbuilds.io/.

ajitsinghkaler · 2020-04-12T13:40:37Z

@gkalpak made the changes but made the event data changes only on few events once we confirm it we can migrate the whole data

mary-poppins · 2020-04-12T13:48:34Z

You can preview 171f7c0 at https://pr36517-171f7c0.ngbuilds.io/.

gkalpak

Thx for making the changes, @ajitsinghkaler 🚀
Here's a second round of comments 😁

aio/src/app/custom-elements/events/events.service.ts

aio/src/app/custom-elements/events/events.component.ts

aio/content/marketing/events.json

aio/src/app/custom-elements/events/events.component.html

aio/src/app/custom-elements/events/events.component.ts

aio/src/app/custom-elements/events/events.component.html

petebacondarwin · 2020-04-15T09:58:38Z

Happy to let @gkalpak take the lead on reviewing this. If you want extra input from me, please re-add me as a reviewer when it is ready.

mary-poppins · 2020-04-18T21:22:20Z

You can preview b473d7b at https://pr36517-b473d7b.ngbuilds.io/.

ajitsinghkaler · 2020-04-18T21:28:30Z

@gkalpak made the changes please have a look

mary-poppins · 2020-04-18T21:51:29Z

You can preview 8d3bd94 at https://pr36517-8d3bd94.ngbuilds.io/.

ajitsinghkaler · 2020-04-20T05:44:22Z

I will make linting changes later

aio/src/app/custom-elements/events/events.component.ts

gkalpak · 2020-09-13T15:08:44Z

@ajitsinghkaler, could you rebase this and fix conflicts?

Data in events page was hardcoded and it is manually moved in the table. Created a new events widget which will automatically move past and upcoming events from events.json (`aio/content/marketing/events.json`) file to the relevant table in the events tab

In the events.json file most of tooltips are same as name so there were of no use, as they were providing no extra information. So, removed them from the events.json file

…cases This commit simplifies the tests of `EventsComponent` (by introducing a `createMockEvent()` helper and getting rid of the irrelevant `Event` fields) and adds tests for some more usecases. It also makes the tests more robust by using Jasmine's `Clock` to mock the current date.

mary-poppins · 2020-09-15T04:08:01Z

You can preview d73cfd2 at https://pr36517-d73cfd2.ngbuilds.io/.

ajitsinghkaler · 2020-09-15T04:25:10Z

@gkalpak rebased it tell me anything else needed

gkalpak

Reviewed-for: global-docs-approvers

IgorMinar

LGTM! Thank you!

Reviewed-for: global-approvers, size-tracking

In the events.json file most of tooltips are same as name so there were of no use, as they were providing no extra information. So, removed them from the events.json file PR Close #36517

…cases (#36517) This commit simplifies the tests of `EventsComponent` (by introducing a `createMockEvent()` helper and getting rid of the irrelevant `Event` fields) and adds tests for some more usecases. It also makes the tests more robust by using Jasmine's `Clock` to mock the current date. PR Close #36517

Data in events page was hardcoded and it is manually moved in the table. Created a new events widget which will automatically move past and upcoming events from events.json (`aio/content/marketing/events.json`) file to the relevant table in the events tab PR Close #36517

In the events.json file most of tooltips are same as name so there were of no use, as they were providing no extra information. So, removed them from the events.json file PR Close #36517

…cases (#36517) This commit simplifies the tests of `EventsComponent` (by introducing a `createMockEvent()` helper and getting rid of the irrelevant `Event` fields) and adds tests for some more usecases. It also makes the tests more robust by using Jasmine's `Clock` to mock the current date. PR Close #36517

angular-automatic-lock-bot · 2020-10-17T16:26:47Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 8, 2020

pullapprove bot requested review from petebacondarwin and StephenFluin April 8, 2020 16:53

atscott added the comp: docs-infra label Apr 9, 2020

ngbot bot added this to the needsTriage milestone Apr 9, 2020

gkalpak added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release feature Issue that requests a new feature labels Apr 12, 2020

gkalpak modified the milestones: needsTriage, docs-infra-aio-app Apr 12, 2020

gkalpak added this to REVIEW in docs-infra Apr 12, 2020

gkalpak requested changes Apr 12, 2020

View reviewed changes

ajitsinghkaler requested a review from gkalpak April 12, 2020 13:39

gkalpak requested changes Apr 13, 2020

View reviewed changes

petebacondarwin removed their request for review April 15, 2020 09:58

ajitsinghkaler force-pushed the events branch from 313341c to b473d7b Compare April 18, 2020 21:13

ajitsinghkaler requested a review from gkalpak April 18, 2020 21:25

gkalpak requested changes Apr 21, 2020

View reviewed changes

aio/src/app/custom-elements/events/events.component.ts Outdated Show resolved Hide resolved

aio/src/app/custom-elements/events/events.component.ts Outdated Show resolved Hide resolved

aio/src/app/custom-elements/events/events.component.ts Outdated Show resolved Hide resolved

ajitsinghkaler force-pushed the events branch from 8d3bd94 to 53c2708 Compare April 23, 2020 17:31

ngbot bot removed this from the docs-infra-aio-app milestone Jul 29, 2020

josephperrott added the comp: docs-infra label Jul 29, 2020

ngbot bot added this to the needsTriage milestone Jul 29, 2020

josephperrott mentioned this pull request Jul 29, 2020

Received "error - Internal error" from pullapprove dropseed/pullapprove-support#132

Closed

ajitsinghkaler and others added 6 commits September 15, 2020 09:23

fixup! feat(docs-infra): created new widget for events page

ca8c78e

fixup! feat(docs-infra): created new widget for events page

61abef0

refactor(docs-infra): remove tooltip from links same as name

1bfee06

In the events.json file most of tooltips are same as name so there were of no use, as they were providing no extra information. So, removed them from the events.json file

fixup! feat(docs-infra): created new widget for events page

d73cfd2

ajitsinghkaler force-pushed the events branch from 647476a to d73cfd2 Compare September 15, 2020 03:55

gkalpak removed request for alxhub and pkozlowski-opensource September 15, 2020 13:25

gkalpak approved these changes Sep 15, 2020

View reviewed changes

petebacondarwin marked this pull request as draft September 15, 2020 16:04

petebacondarwin marked this pull request as ready for review September 15, 2020 16:05

IgorMinar approved these changes Sep 16, 2020

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 16, 2020

AndrewKushnir closed this in 5b33798 Sep 16, 2020

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(docs-infra): created new widget for events page #36517

feat(docs-infra): created new widget for events page #36517

ajitsinghkaler commented Apr 8, 2020 •

edited

ajitsinghkaler commented Apr 8, 2020

mary-poppins commented Apr 12, 2020

gkalpak left a comment

mary-poppins commented Apr 12, 2020

ajitsinghkaler commented Apr 12, 2020

mary-poppins commented Apr 12, 2020

gkalpak left a comment

petebacondarwin commented Apr 15, 2020

mary-poppins commented Apr 18, 2020

ajitsinghkaler commented Apr 18, 2020

mary-poppins commented Apr 18, 2020

ajitsinghkaler commented Apr 20, 2020 •

edited

gkalpak commented Sep 13, 2020

mary-poppins commented Sep 15, 2020

ajitsinghkaler commented Sep 15, 2020 •

edited

gkalpak left a comment

IgorMinar left a comment

angular-automatic-lock-bot bot commented Oct 17, 2020

feat(docs-infra): created new widget for events page #36517

feat(docs-infra): created new widget for events page #36517

Conversation

ajitsinghkaler commented Apr 8, 2020 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

ajitsinghkaler commented Apr 8, 2020

mary-poppins commented Apr 12, 2020

gkalpak left a comment

Choose a reason for hiding this comment

mary-poppins commented Apr 12, 2020

ajitsinghkaler commented Apr 12, 2020

mary-poppins commented Apr 12, 2020

gkalpak left a comment

Choose a reason for hiding this comment

petebacondarwin commented Apr 15, 2020

mary-poppins commented Apr 18, 2020

ajitsinghkaler commented Apr 18, 2020

mary-poppins commented Apr 18, 2020

ajitsinghkaler commented Apr 20, 2020 • edited

gkalpak commented Sep 13, 2020

mary-poppins commented Sep 15, 2020

ajitsinghkaler commented Sep 15, 2020 • edited

gkalpak left a comment

Choose a reason for hiding this comment

IgorMinar left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Oct 17, 2020

ajitsinghkaler commented Apr 8, 2020 •

edited

ajitsinghkaler commented Apr 20, 2020 •

edited

ajitsinghkaler commented Sep 15, 2020 •

edited