-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: getting started guide use pipe before introduction #36584
Conversation
You can preview 18d35ef at https://pr36584-18d35ef.ngbuilds.io/. |
1 similar comment
You can preview 18d35ef at https://pr36584-18d35ef.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @ajitsinghkaler!
Please use proper sentences in the commit message to make it more readable (i.e. use capitalization, punctuation, etc.):
In "Getting started" guide pipes are not intoduced anywhere but are used in the guide.
Added refrence to pipes for better consistency in the tutorial.
aio/content/start/start-data.md
Outdated
|
||
<div class="alert is-helpful"> | ||
|
||
The operator `|` used for currency on product.price is called a pipe. For more information about Angular pipes, see [Pipes](guide/pipes "Pipes"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
product.price
--> `product.price`
Also, the sentence now makes it sound as if |
is called a pipe (which it's not). We should re-phrase to make it clear that |
is the "pipe operator" and currency
is the pipe (which is not a great name, but that's what we gone with 🤷♂️).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! Here's a suggestion that I think might help. It puts more focus on the currency pipe than the operator, and provides a brief description of what a pipe is for.
The operator `|` used for currency on product.price is called a pipe. For more information about Angular pipes, see [Pipes](guide/pipes "Pipes"). | |
The line, `<h4>{{ product.price | currency }}</h4>` uses the `currency` pipe to transform `product.price` from number to a currency string. A pipe is a way you can transform data in your HTML template. For more information about Angular pipes, see [Pipes](guide/pipes "Pipes"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! I offered a suggestion. Let me know what you think.
aio/content/start/start-data.md
Outdated
|
||
<div class="alert is-helpful"> | ||
|
||
The operator `|` used for currency on product.price is called a pipe. For more information about Angular pipes, see [Pipes](guide/pipes "Pipes"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! Here's a suggestion that I think might help. It puts more focus on the currency pipe than the operator, and provides a brief description of what a pipe is for.
The operator `|` used for currency on product.price is called a pipe. For more information about Angular pipes, see [Pipes](guide/pipes "Pipes"). | |
The line, `<h4>{{ product.price | currency }}</h4>` uses the `currency` pipe to transform `product.price` from number to a currency string. A pipe is a way you can transform data in your HTML template. For more information about Angular pipes, see [Pipes](guide/pipes "Pipes"). |
18d35ef
to
38d64ef
Compare
In "Getting started" guide pipes are not intoduced anywhere but are used in the guide. Added refrence to pipes for better consistency in the tutorial. Fixes angular#36375
38d64ef
to
c8252e9
Compare
@aikidave @gkalpak made the changes please have a look |
You can preview c8252e9 at https://pr36584-c8252e9.ngbuilds.io/. |
Co-Authored-By: David Shevitz <dshevitz@google.com>
You can preview e678339 at https://pr36584-e678339.ngbuilds.io/. |
@aikidave @gkalpak made the change please have a look |
@aikidave can you please add the merge label |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
in getting started guide pipes are not intoduced anywhere but are used in guide added refrence to pipes for better consistency in the tutorial
Fixes #36375
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Pipes used before it were referenced
Issue Number: #36375
What is the new behavior?
Pipes referenced on the first tutorial when they are used
Does this PR introduce a breaking change?
Other information