Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Andrew Grekov to GDE resources #36690

Closed
wants to merge 1 commit into from

Conversation

thekiba
Copy link
Contributor

@thekiba thekiba commented Apr 17, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

cc @StephenFluin

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @thekiba and congratulations! We just need to get the tests passing. Try this for your commit message To meet the 100 character minimum requirement in the body:

docs: add Andrew Grekov to GDE resources

This commit adds Andrew Grekov to the GDE 
resources page and describes his work as a software 
engineer using angular and .NET.

Notice the blank line before and after the body.

Rebasing should also help you pass the tests.

Here are my notes on amending commit and rebasing, but if you need help with anything just let me know and I can help from this end.

"picture": "thekiba.jpg",
"twitter": "thekiba_io",
"website": "https://thekiba.io",
"bio": "Andrew is a software engineer using Angular and .NET. He spends most of his spare time staying up to date, helping other people and experimenting with web tech.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bio": "Andrew is a software engineer using Angular and .NET. He spends most of his spare time staying up to date, helping other people and experimenting with web tech.",
"bio": "Andrew is a software engineer using Angular and .NET. He spends most of his spare time staying up-to-date, helping other people, and experimenting with web tech.",

The comma after "people" isn't a requirement. It is a style that we use in the docs, though, so you'll see it around angular.io. Totally up to you. :)

@kapunahelewong kapunahelewong added effort1: hours action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews risk: low feature Issue that requests a new feature labels Jun 29, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 29, 2020
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Jun 29, 2020
@thekiba
Copy link
Contributor Author

thekiba commented Jul 30, 2020

Thanks for your help, @kapunahelewong! I have updated this pr and force pushed it. Hope that it's good now 🦊

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @thekiba!

Reviewed-for: global-docs-approvers

@kapunahelewong kapunahelewong added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 3, 2020
@thekiba
Copy link
Contributor Author

thekiba commented Sep 7, 2020

@kapunahelewong it seems that I should make a rebase and force push it again, right?

@kapunahelewong
Copy link
Contributor

Yes, @thekiba, that would be great. Here are my notes on rebasing if you'd like to refer to them. If you have any questions just let me know and I can help you. Once it's rebased and passing all the tests we can mark it for merge!

@thekiba
Copy link
Contributor Author

thekiba commented Sep 8, 2020

Thanks for your help, @kapunahelewong! Hope that it's good now 🦊

This commit adds Andrew Grekov to the GDE
resources page and describes his work as a software
engineer using angular and .NET.
@thekiba
Copy link
Contributor Author

thekiba commented Sep 9, 2020

@kapunahelewong I waited until the tests on the master were successful and rebased again. And now the sauce labs test is not passed. Could you please look at this? 😅

@petebacondarwin
Copy link
Member

It's most likely a flakey test. I have restarted the failing job.

@kapunahelewong kapunahelewong added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 9, 2020
atscott pushed a commit that referenced this pull request Sep 9, 2020
This commit adds Andrew Grekov to the GDE
resources page and describes his work as a software
engineer using angular and .NET.

PR Close #36690
@atscott atscott closed this in 3d77b64 Sep 9, 2020
kyliau pushed a commit to kyliau/angular that referenced this pull request Sep 9, 2020
This commit adds Andrew Grekov to the GDE
resources page and describes his work as a software
engineer using angular and .NET.

PR Close angular#36690
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants