New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Andrew Grekov to GDE resources #36690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @thekiba and congratulations! We just need to get the tests passing. Try this for your commit message To meet the 100 character minimum requirement in the body:
docs: add Andrew Grekov to GDE resources
This commit adds Andrew Grekov to the GDE
resources page and describes his work as a software
engineer using angular and .NET.
Notice the blank line before and after the body.
Rebasing should also help you pass the tests.
Here are my notes on amending commit and rebasing, but if you need help with anything just let me know and I can help from this end.
"picture": "thekiba.jpg", | ||
"twitter": "thekiba_io", | ||
"website": "https://thekiba.io", | ||
"bio": "Andrew is a software engineer using Angular and .NET. He spends most of his spare time staying up to date, helping other people and experimenting with web tech.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"bio": "Andrew is a software engineer using Angular and .NET. He spends most of his spare time staying up to date, helping other people and experimenting with web tech.", | |
"bio": "Andrew is a software engineer using Angular and .NET. He spends most of his spare time staying up-to-date, helping other people, and experimenting with web tech.", |
The comma after "people" isn't a requirement. It is a style that we use in the docs, though, so you'll see it around angular.io. Totally up to you. :)
Thanks for your help, @kapunahelewong! I have updated this pr and force pushed it. Hope that it's good now 🦊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, @thekiba!
Reviewed-for: global-docs-approvers
@kapunahelewong it seems that I should make a rebase and force push it again, right? |
Yes, @thekiba, that would be great. Here are my notes on rebasing if you'd like to refer to them. If you have any questions just let me know and I can help you. Once it's rebased and passing all the tests we can mark it for merge! |
Thanks for your help, @kapunahelewong! Hope that it's good now 🦊 |
This commit adds Andrew Grekov to the GDE resources page and describes his work as a software engineer using angular and .NET.
@kapunahelewong I waited until the tests on the master were successful and rebased again. And now the sauce labs test is not passed. Could you please look at this? 😅 |
It's most likely a flakey test. I have restarted the failing job. |
This commit adds Andrew Grekov to the GDE resources page and describes his work as a software engineer using angular and .NET. PR Close #36690
This commit adds Andrew Grekov to the GDE resources page and describes his work as a software engineer using angular and .NET. PR Close angular#36690
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
cc @StephenFluin