Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add AndrewKushnir to the fw-testing group #36744

Closed

Conversation

AndrewKushnir
Copy link
Contributor

This commit update the PullApprove config to add AndrewKushnir to the fw-testing group. The reason for this change is that I was involved into TestBed rewrite (for Ivy) and it belongs to the fw-testing group ownership.

PR Type

What kind of change does this PR introduce?

  • Build related changes

Does this PR introduce a breaking change?

  • Yes
  • No

This commit update the PullApprove config to add AndrewKushnir to the `fw-testing` group. The reason for this change is that I was involved into TestBed rewrite (for Ivy) and it belongs to the `fw-testing` group ownership.
@AndrewKushnir AndrewKushnir added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 21, 2020
@ngbot ngbot bot added this to the needsTriage milestone Apr 21, 2020
@pullapprove pullapprove bot requested a review from IgorMinar April 21, 2020 18:52
@AndrewKushnir AndrewKushnir requested a review from kara April 21, 2020 18:52
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since Andrew has done most of the TestBed fixes/updates lately.

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Apr 21, 2020
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 21, 2020
matsko pushed a commit that referenced this pull request Apr 22, 2020
This commit update the PullApprove config to add AndrewKushnir to the `fw-testing` group. The reason for this change is that I was involved into TestBed rewrite (for Ivy) and it belongs to the `fw-testing` group ownership.

PR Close #36744
@matsko matsko closed this in 4275b34 Apr 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants